Skip to content

test(sdk): use a deployment id the schema pattern accepts - #437

Closed
ItamarZand88 wants to merge 1 commit into
mainfrom
itamar/alien-535-sdk-reconcile-test-id
Closed

test(sdk): use a deployment id the schema pattern accepts#437
ItamarZand88 wants to merge 1 commit into
mainfrom
itamar/alien-535-sdk-reconcile-test-id

Conversation

@ItamarZand88

Copy link
Copy Markdown
Contributor

Summary

The reconcile round-trip test added in #432 uses a 24-character deployment id, and the platform spec pins deployment ids to dep_ + 28 characters, so the request never deserializes and alien-platform-api's tests fail on main. This gives the test an id the schema accepts.

When the test runs:

  1. It builds a reconcile request with a deployment id and a runtime-metadata state.
  2. The generated request type validates the id against the spec pattern before anything else — with 24 characters that step fails and the test never reaches its assertions.
  3. With a 28-character id it deserializes and the round-trip assertions run.

This changes the test's fixture id to one the schema pattern accepts.

How I tested

  • cargo test -p alien-platform-api reconcile_state_preserves — fails on main with doesn't match pattern "dep_[0-9a-z]{28}$", passes with this change.

The reconcile round-trip test used a 24-character id, and the platform
spec pins deployment ids to 28, so the request never deserialized and
the test failed on main.
@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown

Greptile Summary

This PR corrects a Rust SDK test fixture so its deployment ID satisfies the platform schema and allows the reconcile round-trip assertions to execute.

  • Extends the fixture’s deployment ID suffix from 24 to 28 characters.
  • Leaves production behavior and the test’s asserted runtime-metadata values unchanged.

Confidence Score: 5/5

The PR appears safe to merge because the updated fixture satisfies the deployment ID schema without changing production behavior or test semantics.

The replacement ID has the required 28-character lowercase alphanumeric suffix, allowing deserialization to reach the existing runtime-metadata round-trip assertions.

Important Files Changed

Filename Overview
client-sdks/platform/rust/src/lib.rs Updates one test fixture to use a schema-compliant deployment ID; no actionable issues found.

Reviews (1): Last reviewed commit: "test(sdk): use a deployment id the schem..." | Re-trigger Greptile

@ItamarZand88

Copy link
Copy Markdown
Contributor Author

Superseded on main by #419 (feat: harden BYOC deployment workflows), which fixed the same defect independently: the test's deploymentId now matches dep_[0-9a-z]{28} (dep_0000000000000000000000000000). Rebased onto main this PR becomes empty — 0 commits — and the test it existed to fix passes on main (6/6 in alien-platform-api). Closing rather than merging nothing. The sandbox stack (#387 onward) has been rebased onto current main and no longer carries this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant