Skip to content

fix(app): prevent stale session tab reads #39767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brendonovich merged 2 commits into from
Jul 31, 2026
Merged

fix(app): prevent stale session tab reads #39767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e05f9f0
fix(app): prevent stale session tab reads
OpeOginni Jul 30, 2026
5393251
fix(app): stabilize titlebar portals
OpeOginni Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/app/src/components/session/session-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,9 @@ export function SessionHeader() {

return (
<>
<Show when={search() && centerMount()}>
<Show when={search() && centerMount()} keyed>
{(mount) => (
<Portal mount={mount()}>
<Portal mount={mount}>
<Button
type="button"
variant="ghost"
Expand All @@ -308,20 +308,20 @@ export function SessionHeader() {
</span>
</div>

<Show when={hotkey()}>
<Show when={hotkey()} keyed>
{(keybind) => (
<Keybind class="shrink-0 !border-0 !bg-transparent !shadow-none px-0 text-text-weaker">
{keybind()}
{keybind}
</Keybind>
)}
</Show>
</Button>
</Portal>
)}
</Show>
<Show when={rightMount()}>
<Show when={rightMount()} keyed>
{(mount) => (
<Portal mount={mount()}>
<Portal mount={mount}>
<Show
when={isV2}
fallback={
Expand Down
5 changes: 3 additions & 2 deletions packages/app/src/components/titlebar-tab-nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,15 +224,16 @@ export function TabNavItem(props: {
<span data-slot="project-avatar-slot" class="flex size-4 shrink-0 items-center justify-center">
<Show
when={props.session()}
keyed
fallback={
<span class="block size-4 rounded-[3px] border border-v2-border-border-muted" aria-hidden="true" />
}
>
{(session) => (
<SessionTabAvatar
project={project()}
directory={session().directory}
sessionId={session().id}
directory={session.directory}
sessionId={session.id}
server={props.server}
/>
)}
Expand Down
4 changes: 2 additions & 2 deletions packages/app/src/pages/new-session/new-session-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ export function NewSessionStatus(props: { mount: Accessor<HTMLElement | null>; v
const language = useLanguage()

return (
<Show when={props.mount()}>
<Show when={props.mount()} keyed>
{(mount) => (
<Portal mount={mount()}>
<Portal mount={mount}>
<Show when={props.visible()}>
<Tooltip placement="bottom" value={language.t("status.popover.trigger")}>
<StatusPopoverV2 />
Expand Down
Loading