fix(app): prevent stale session tab reads - #39767
Merged
Merged
Conversation
Contributor
Author
|
Haha, thanks for the Merge Brendan, but I wasnt completely done with the fix, slept off lol. Ill make a new one now |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #39766
Closes #39704
Type of change
What does this PR do?
Session and project navigation could update titlebar content while Solid was transitioning away from the previous view. Several callback-form
<Show>components exposed guarded accessors to titlebar avatars and portals, allowing their children to read those accessors after the conditions were disposed and crash the desktop renderer withStale read from <Show>.This keys those
<Show>boundaries and passes their captured values directly to the avatar, portals, and keybind. The titlebar children now receive stable values during teardown instead of reading disposed narrowing accessors.How did you verify your code works?
bun typecheckinpackages/app.bun test --conditions=browser --preload ./happydom.ts ./test-browser/solid-router-cleanup.test.tsinpackages/app.git diff --check.Screenshots / recordings
Not applicable; this fixes renderer crashes without changing the UI.
Checklist