Repository navigation
fix(tui): hide error hint when MCP Enter starts sign-in - #49403
Merged
Merged
Conversation
kitlangton
enabled auto-merge (squash)
September 16, 2026 19:32
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since #48939,
needs_authMCP servers carry a requirederrorreason. That madestatusError()treat them as error-bearing, so the dialog footer renderedenter to view errorfor servers like stripe or uidotsh. But Enter does not open an error view for these servers: when the server has an integration, it starts the sign-in flow. The hint was wrong.What Changes
The footer hint now matches what Enter actually does:
needs_authwith integration (e.g. stripe)enter to view error sign in spacesign in spaceneeds_authwithout integrationenter to view error spacefailedenter to view error spaceBefore: MCP servers dialog for a sign-in-gated server shows
enter to view erroreven though Enter opens sign-in.After: the footer only offers
sign in space.Demo
Side-by-side recording of the same fixture MCP server (a remote endpoint returning 401, so it lands in
needs_authwith an integration) against the pre-fix baseline (left,BEFOREmark) and this branch (right,AFTERmark). Both run the identical/mcpsdialog; only the footer hint differs. See the attachedmcp-footer-before-after.mp4.Scope
This PR only changes the focused-server footer logic in
DialogMcp. TheNeeds authentication: <reason>line in the server status dialog is informational and intentionally unchanged.Verification
v2with the exact footer from the bug report (enter to view error sign in space) and passes with the fix.bun run checkfrom the repo root: lint + typecheck clean (also enforced by the pre-push hook).v2vs this branch against a live 401 MCP endpoint.mcp-footer-before-after.mp4