Skip to content

fix(tui): hide error hint when MCP Enter starts sign-in #49403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kitlangton merged 1 commit into from
Sep 16, 2026
Merged

fix(tui): hide error hint when MCP Enter starts sign-in #49403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/tui/src/component/dialog-mcp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ export function DialogMcp(props: { initialServer?: string; details?: boolean } =

const focusedError = createMemo(() => {
const server = focusedServer()
// Enter starts sign-in for auth-gated integrations instead of showing the auth reason
if (server?.status.status === "needs_auth" && server.integrationID) return undefined
return server ? statusError(server.status) : undefined
})

Expand Down
3 changes: 2 additions & 1 deletion packages/tui/test/cli/tui/dialog-mcp.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ test.each(["enter", "space"])("starts OAuth with %s for an MCP server requiring

try {
await fixture.app.waitForFrame((frame) => frame.includes("Sign in required"))
expect(fixture.app.captureCharFrame()).not.toContain("enter to view error")
if (key === "enter") fixture.app.mockInput.pressEnter()
else fixture.app.mockInput.pressKey(" ")
await fixture.app.waitForFrame((frame) => frame.includes("Waiting for authorization"))
Expand Down Expand Up @@ -79,7 +80,7 @@ async function renderMcp(options?: { failed?: boolean; location?: { directory: s
name: "linear",
status: options?.failed
? { status: "failed", error: "MCP error -32000: Connection closed" }
: { status: "needs_auth" },
: { status: "needs_auth", error: "Authentication required" },
integrationID: "mcp_linear",
},
],
Expand Down
Loading