Skip to content

fix(desktop): persist rail grouping across restarts - #3099

Merged
likun666661 merged 2 commits into
apache:mainfrom
1625567290:fix/desktop-rail-view-mode-persist
Aug 16, 2026
Merged

fix(desktop): persist rail grouping across restarts#3099
likun666661 merged 2 commits into
apache:mainfrom
1625567290:fix/desktop-rail-view-mode-persist

Conversation

@1625567290

Copy link
Copy Markdown
Contributor

Summary

viewMode (按时间 / 按项目) lived in useState<SessionViewMode>('conversation'), so the rail grouping control reset to 按时间 on every launch. After #3033 the control is permanent sticky chrome, so the silent revert is visible every start.

Grouping now uses the same localStorage seam as the rail's collapsed flag (session-list-layout.ts):

  • readSessionListViewMode() hydrates the shell
  • writeSessionListViewMode() persists through useAppShellPersistenceEffects
  • unknown / empty stored values fail open to conversation

Fixes #3060

Verification

  • npx biome check on the four changed files — clean
  • npx tsc -p tsconfig.renderer.json --noEmit — clean
  • npm --workspace @maka/desktop test860/860, including the new persist/hydrate cases
  • Red: the new test failed to import readSessionListViewMode / writeSessionListViewMode before the production helpers existed

Not run: desktop e2e / Electron window. The official desktop unit suite covers the persist/hydrate contract.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope:

Grok authored the implementation, tests, and this PR description.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

viewMode was a hard-coded useState('conversation'), so the rail grouping
control reset to time-order on every launch. Hydrate and persist it
through the same localStorage seam as the rail's collapsed flag.

Fixes apache#3060

Generated-by: Grok
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@1625567290, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Limit details: You’ve used all 3 included reviews currently available under your plan.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8ad0a9b7-1e99-410c-b44d-4576b57803e9

📥 Commits

Reviewing files that changed from the base of the PR and between 2666a57 and 9c83001.

📒 Files selected for processing (5)
  • apps/desktop/e2e/sidebar-project-row.spec.ts
  • apps/desktop/src/main/__tests__/session-list-layout.test.ts
  • apps/desktop/src/renderer/app-shell-effects.ts
  • apps/desktop/src/renderer/app-shell.tsx
  • apps/desktop/src/renderer/session-list-layout.ts

Comment @coderabbitai help to get the list of available commands.

Click 按项目, wait for the localStorage write, reload the Electron
renderer, and assert the control is still project-grouped.

Generated-by: Grok
@1625567290

Copy link
Copy Markdown
Contributor Author

Full-chain follow-up is on this branch.

Official Electron e2e against the production desktop build:

env -u ELECTRON_RUN_AS_NODE npx playwright test --config e2e/playwright.config.ts e2e/sidebar-project-row.spec.ts
  • existing rail keyboard/project-row journey: pass
  • new rail grouping survives a renderer reload: pass (2/2, 14.2s)

The new case clicks 按项目, waits for maka-chat-list-view-mode-v1=project, reloads the renderer, and asserts the segmented control is still 按项目.

@likun666661
likun666661 merged commit 4bded3b into apache:main Aug 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rail grouping (按时间 / 按项目) does not persist across restarts

2 participants