refactor(desktop): rebuild the task rail on one shape and one vocabulary

[Astro-Han]

Summary

The task rail (sidebar) rebuild from #2984, PR 2 of 3. #2985 has merged; this targets main.

The rail carried four kinds of chrome that each answered a question nobody was asking. A ➕ on every group header was the 新任务 row's handler under a second name, three rows below the row itself. A list heading labelled a list that is the only thing under it, and existed mainly to give the grouping switch somewhere to sit. A 会话 nav row selected a section whose content was already on screen directly beneath it. And a 导入 row opened a modal over the conversation for a rare setup errand that needs a source, a filter and a paged directory. All four are gone.

What is left is one shape. The top region is 新任务 plus the two sections that are somewhere else — 扩展 and 定时任务 — and a full-width grouping switch, sticky above the history it governs. Tasks have no row of their own, because the list is the row: clicking any task selects that section, and the section is where you are unless you went somewhere. Every task row carries two visible slots: a status dot, and a timestamp that becomes the ⋯ menu on hover or keyboard focus.

Import becomes 设置 › 活动 › 导入任务, beside 已归档任务. As a page it needs no selection state: 导入 sits on the row, the way 恢复 sits on the archived page's rows. That retires ExternalSessionImportLifecycle, which held a dialog open until its import finished — and whose real job, missed here until review, was keeping one intent from becoming two tasks; the Host now holds that invariant instead (see below). The source switch now appears only when there is more than one source — Codex is the only adapter that ships, so every user was being shown a segmented control with one segment.

The terminology pass: the same object was 会话, 对话, session or conversation depending on the file. Code, protocol and storage keep session; every string a user reads now says 任务 / task. The rule is what the noun refers to, so conversing as a behavior stays 对话, another agent's stored conversations stay 对话 (导入任务 lists Codex's conversations and produces Maka tasks), 侧边对话 stays, and <session-id> stays a CLI contract. Two collisions needed resolving rather than renaming: the per-task ledger was 会话任务, which would have become 任务任务 — its items are 待办 / to-dos; and the automations row read "定时任务，N 个未完成任务", which now says "N 条进行中".

Refs #2984

Screens

The rail, both sides at the same 260px width, from story Product/Sidebar Session List › ConversationStates — the story that also covers all eight statuses.

What moved, top to bottom: the 会话 nav row gone, leaving 新任务 and the two sections that are elsewhere; the list heading and its ➕ replaced by the full-width 按时间 / 按项目 switch; the status dot moved to the leading edge and the timestamp took the trailing slot it shares with the ⋯ menu; the 已过期 pill gone, with the row's dimming carrying stale visually and the accessible name carrying it for everyone else. The colour change on 待审核的文件 diff is the point of the semantic pass — review is attention, not a second shade of "live".

What an adversarial review changed

The first seven commits made five claims about this codebase that are false, and a ⋯-menu claim that is false in the other direction. They are listed here because the fixes only make sense against them, and because four of the six were caught by review rather than by me.

Claimed	Actually
The 「会话」row only selected a tautological filter	It carried a dead filter, but its onClick was also the only control selecting {section:'sessions'}. Deleting it on the filter argument was deleting the right row for the wrong reason — see the note below, which deletes it again on the real one
The stale pill duplicated the timestamp beside it	Stale means "this task's model connection is unavailable"; it has nothing to do with time
Two tones had no distinct outcome, so archived/aborted draw no dot	info → accent had none; muted → neutral drew a real dot. Dropping them to undefined was a behaviour change, described as a consequence of collapsing a layer
The dot reads runningTurnIds, the running authority	No SessionSummary reaching Desktop carries that field — the identifier appears nowhere in packages/runtime-host/src or apps/desktop/src/main outside a test fixture
Nothing ever wrote review/done, so no stored record can carry them	resolveLegacyStatus in the JSONL importer (removed in #2656) passed both through into real SQLite stores verbatim
The ⋯ menu is no longer permanently mounted	It is, and deliberately should be — opacity: 0 is what keeps it in the tab order and the accessibility tree

The corrections, in the order they were made:

Status goes through the shared semantic layer. Deleting SessionStatusTone was right; replacing it with a private SessionStatus → StatusDotVariant table was not, because status-vocabulary.ts already owns "the one place a status word becomes a colour". The private table made a second authority and the two disagreed: a task waiting on a permission prompt drew error in the rail while the permission centre drew attention for the identical condition. The enum now maps to StatusSemantic and dotForStatus picks the colour. blocked and waiting_for_user are both attention — both are waiting on a person, which is what that semantic is defined as; using colour to tell them apart was using colour for a distinction it cannot carry.

review and done are restored. SESSION_STATUSES is read back out of storage and normalizeSessionHeader throws for the whole header on an unrecognised status, so one stored row carrying done fails an entire catalog page. Narrowing it is a data migration with its own review, not a cleanup — filed as #3058.

The row keeps its facts. Collapsing to a single signal inside the resolver made the visual element the only carrier of the fact, so removing the trailing Badge removed "stale" itself: staleTitle and staleAriaLabel were left with no reader, and the surviving opacity cue is cancelled on the selected row by design and announces nothing anyway. Worktree went the same way — an aria-labeled icon inside the button became a title on a non-interactive ancestor, which contributes to neither the button's name nor its description. The row now resolves a list of signals, draws signals[0], and puts the rest plus worktree and the absolute timestamp in one visually hidden span inside the button. Two slots, same pixels. Signals also stop eating each other: aborted keeps its own dot instead of falling through to the unread branch, where an aborted task with unread text drew the same accent dot as a running one.

Import. The success path already emitted sessions:changed (since #2507), so a task imported while the user leaves Settings does reach the rail — the comment claiming otherwise is corrected. The real gap was commit_outcome_unknown, which returned without emitting: the only trace was the page's own banner, and leaving the page unmounts it, which is exactly when someone comes back and imports the same conversation again.

Gates. Deleting the import dialog left exact-string readers behind: scripts/check-astryx-alignment.mjs exited 1 with ENOENT, and the surface inventory still listed both deleted files with no row for the page replacing them. The dialog's Item-row guards are dropped rather than migrated — they checked that a selected row stayed keyboard-reachable, and the new page has no selection.

Terminology. Same-surface contradictions the rule pass left behind: the to-do panel's error banner said 任务载入失败 next to a 重新载入待办 button; chat-readiness said 当前任务 then 新建会话 in one sentence; the bot's help offered to 清空当前对话开新会话 while the reply to that command said 任务已重置. Plus zh/en divergence in Daily Review and the terminal panel, tool-activity/copy.ts missed outright, and the CLI's own prose.

A later CodeRabbit round

Twelve findings, each traced to source before deciding. Eight accepted: two doc claims in session-status-presentation.ts that survived their own subject moving to @maka/ui; a dead copy binding; streaming and hasUnread still writing 'accent' by hand after the rest of the row moved onto dotForStatus; a restored-task fixture flipping isArchived without status, which no store writes; a 导入任务 story fixture that ignored includeArchived and cursor under a comment claiming it demonstrated both; a duplicated fake_backend sentence the rename had to edit twice; and English project help that made the task the actor.

Four declined, with the code in each thread. The largest was commit_outcome_unknown "not refreshing the catalog" — it does, from Desktop Main, and the suggested remedy would have threaded a second notification path through three renderer layers past the IPC event that already carries it. One would have reverted a fix: the in-session to-do ledger's error copy must stay 待办, because 任务 now names the session, and calling both 任务 is the collision this PR resolves.

Shooting the before/after above then found two gaps of its own, in the story that exists to show every status: review and done were never restored to the fixture when the enum came back, and StoryFrame was 20px narrower than the rail it framed — clipping exactly the trailing slot this change introduces.

The 任务 row, deleted twice

Worth stating plainly because the middle of this branch has it both ways. It was deleted first on a false premise, restored when an E2E test caught that premise, and is deleted again here on the argument that actually holds.

The restore rested on "collapsed, 扩展 and 定时任务 are one-way doors". That is wrong. Collapsed, the rail cannot switch tasks at all — the list is not rendered — so reaching any task already means widening the rail. The titlebar's 展开侧边栏 toggle does that with no guard (ChromeColumnToggle in app-shell-chrome-actions.tsx), it sits next to search and is always visible, and activeId is untouched by a section change, so the widened rail comes back with the task you left already carrying aria-current="page". The row bought one click in a state the user is leaving regardless.

Expanded, it was redundant on its face: it selected a section whose content was rendered directly underneath it, and clicking any task row performs the same selection. That is the identical redundancy as the 会话 list heading deleted one row down — keeping one and deleting the other was the inconsistency.

streaming-remount now returns the way the product offers: widen, then click the row carrying aria-current="page". That is a stronger assertion than the one it replaces, because it checks that the task survives the trip rather than that a button exists.

One import, two tasks

@M4n5ter found the one real regression in this branch, and it is the cost of moving import from a dialog to a page. importingId lives in the page. The import deliberately outlives the page. So leaving 导入任务 mid-import and coming back re-enabled 导入 for a source that was still importing, and nothing downstream deduplicates — treats repeats as independent copies pins that as behaviour. One intent, two tasks to tell apart.

This is exactly what ExternalSessionImportLifecycle was preventing, which the Summary above described as guarding nothing. It is corrected there too.

Fixed at the Host rather than in the page, because the page cannot hold this invariant: a second window or the CLI reproduces the double-import with the page's state fully intact. HostExternalSessionCoordinator.importSession now collapses concurrent requests for the same adapterId + sourceSessionId onto the first attempt's promise, and both callers get its outcome — success or failure — because it is one operation. Sequential repeats are untouched, so importing the same conversation again on purpose still makes an independent copy.

One gap left open and named in the thread: a remounted page still labels a still-importing source 导入 rather than 导入中. Pressing it now yields the right task instead of a duplicate, so this is a label being briefly wrong rather than state being wrong; closing it needs a new "what is in flight" query the page does not have.

Verification

• npm run format:check, npm run lint — clean
• typecheck: @maka/desktop (preload + main + renderer + storybook), @maka/runtime-host, maka-agent; builds for @maka/core, @maka/ui, @maka/storage, @maka/mcp, @maka/runtime, @maka/code-mode
• node scripts/check-astryx-alignment.mjs — ok (exit 1 before this branch's fix)
• Surface inventory regenerated with scripts/generate-astryx-surface-inventory.mjs rather than hand-edited, which also picked up three runtime-host files that arrived from main and were never listed. The check that should have caught either drift is one-directional and not wired into CI — filed as Astryx surface inventory check is one-directional and not wired into CI #3064
• Affected suites: desktop main external-sessions IPC / session-purge / session-ui-state (21), @maka/runtime-host external-session-coordinator (9, including the new coalescing test — verified failing without the fix), @maka/ui session-history-row-actions (2), CLI pi-transcript + pi-tui-runner + run-command (162), plus the suites listed in earlier rounds
• apps/desktop/e2e/streaming-remount.spec.ts — both tests, repeatedly
• Row output verified by SSR against the built @maka/ui: a stale+worktree row now exposes 任务已过期 on the dot and "Git 工作树 · " in the button's accessible name; an aborted row with unread text exposes 已中止 on the dot and 未读消息 in the name; no duplicate 任务列表 landmark
• Rail geometry verified live in Storybook in an earlier round: menu opacity: 0 at rest and 1 on hover and :focus-within, timestamp visibility: hidden in the swap with its width reserved, grouping switch spanning the 新任务 row's box (8→252 at the default width), both labels fitting at the 180px minimum
• npm --workspace @maka/desktop run smoke:storybook — 130 stories render
• The screenshot above is the same story built from main and from this branch, shot headless at the same width; the pipeline is a scratch script, not committed
• Not run: the full repository suite, and the rest of Playwright E2E (CI covers it)

Review focus

The terminology pass touches ~50 files across two rounds. It was applied by rule, then reviewed phrase by phrase — the interesting cases are the deliberate exceptions under Summary.

AI-assisted (Claude Code), including an adversarial review round by Codex and three independent subagents (~50 findings) and a later CodeRabbit round (12). Findings were adjudicated against source rather than applied: seven pushed back across the two rounds, each answered in its thread with the code that contradicts it. CodeRabbit subsequently withdrew two of those on the evidence.

The finding that mattered most came from a human. @M4n5ter's double-import is the only defect in this branch that reaches a user's data, and none of the automated rounds surfaced it — worth stating, given how much of the above is machine-assisted. Everything here is verified by the commands listed; the reviewer should confirm the exceptions read correctly in context.

Follow-ups filed rather than folded in: #3058 (status enum migration), #3059 (Host live-run projection), #3060 (viewMode not persisted), #3061 (streaming-remount flake), #3064 (surface-inventory check).

Checklist

• Tests cover the change and fail without it
• Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

• Yes — described under Summary above
• No

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fddaf289-c57d-4c97-8287-d4db334d19e3

📥 Commits

Reviewing files that changed from the base of the PR and between e812c23 and f2dfdda.

📒 Files selected for processing (5)

• apps/desktop/src/main/chat-readiness.ts
• apps/desktop/src/preload/preload.ts
• apps/desktop/src/renderer/locales/conversation-copy.ts
• apps/desktop/src/renderer/locales/settings-provider-copy.ts
• packages/core/src/connection-error-copy.ts

🚧 Files skipped from review as they are similar to previous changes (5)

• apps/desktop/src/preload/preload.ts
• apps/desktop/src/renderer/locales/settings-provider-copy.ts
• packages/core/src/connection-error-copy.ts
• apps/desktop/src/main/chat-readiness.ts
• apps/desktop/src/renderer/locales/conversation-copy.ts

---

📝 Walkthrough

Problem solved

• Rebuilds the desktop task rail with one flat layout and consistent 任务 / task terminology.
• Removes redundant create controls, the list heading, the 会话 navigation row, rail import, and session filters.
• Moves import to 设置 › 活动 › 导入任务.
• Preserves status, stale, worktree, unread, timestamp, and accessibility information in task rows.
• Refreshes the catalog after uncertain import results.
• Coalesces concurrent imports of the same source while allowing later imports.

Source of truth

The PR extends existing paths. It does not create a parallel task system.

• Task import uses the existing Settings surface and external-session API.
• Status handling uses shared StatusSemantic values and core SessionStatus.
• The rail uses the existing session catalog and storage model.
• session remains in code, protocols, storage, and CLI contracts where required.
• The removed dialog and lifecycle are replaced by the Settings import page and host-level import coordination.

Scope and complexity

The new Settings page owns source selection, archived filtering, pagination, loading, retry, stale-request protection, and uncertain outcomes. These controls are required by the new import location.

The rail now uses an unfiltered sessions section. Task rows render status, timestamps, worktree data, stale state, unread state, and accessible descriptions.

Host-level import coalescing is required to prevent duplicate concurrent imports after the dialog lifecycle was removed. The in-flight map removes completed and failed operations.

The solution is the smallest coherent change shown by the supplied summary. It removes obsolete UI and state paths while retaining the existing catalog, import API, status model, and regression coverage.

Deletions and simplifications

• Deleted the standalone import dialog, lifecycle, stylesheet, and lifecycle tests.
• Removed obsolete import callbacks, session filters, row metadata helpers, and status re-exports.
• Extracted duplicated fake-backend copy into a shared constant.
• Simplified navigation selections to the unfiltered sessions section.
• Retained coverage for import states, uncertain outcomes, navigation, statuses, accessibility, narrow layouts, and concurrent imports.

Further deletion is not evident from the supplied summary without weakening behavior or regression coverage.

Risks

• Import changes could affect source selection, archived-task filtering, pagination, retry behavior, uncertain outcomes, or duplicate prevention.
• Navigation changes could select the wrong task view or alter stored navigation state.
• The rail hides timestamps on touch layouts. Assistive technology still receives the timestamp through the row description.
• Terminology changes affect user-visible UI, notifications, bot messages, CLI output, stories, fixtures, and tests.
• Public contracts changed for RelativeTime, NavSelection, SessionStatusPresentation, SettingsModal, SettingsSurface, ImportTasksSettingsPage, and removed SessionFilter exports.
• The full repository suite and remaining Playwright E2E tests were not run.

Validation

The PR reports passing:

• Formatting and linting.
• Desktop typechecks.
• Affected test suites, including session purge and runtime-host import coordination.
• SSR checks.
• Structural alignment checks.
• Selected E2E tests.
• A 130-story Storybook smoke test.

Stories and fixtures cover import success, failure, unavailable sources, archived tasks, task rows, status fixtures, narrow rails, and Settings integration.

The current checkout has no diff or check artifacts. Required-check status is therefore unverified.

Review-relevant risks

• The diff changes user-visible navigation, terminology, import behavior, accessibility behavior, and CLI messages. Material changes in these areas require independent human review under repository policy.
• The diff changes public component props, exported types, navigation variants, and status presentation contracts. Material public-contract changes require independent human review under repository policy.
• No security, licensing, release, or governance effect was identified in the current diff.
• The person performing the merge reviews the final diff. A maintainer makes the final determination.

Walkthrough

The change adds task import settings, removes filtered session navigation, updates task-row status and timestamp presentation, and replaces session-oriented terminology across desktop, CLI, core, runtime, UI, tests, stories, and validation scripts.

Changes

Task workspace experience

Layer / File(s)	Summary
Task workspace changes apps/desktop/src/renderer/..., packages/ui/src/..., packages/cli/src/..., packages/core/src/..., packages/runtime*/src/..., apps/desktop/e2e/..., apps/desktop/stories/...	Adds task importing through Settings, removes the chats navigation filter, updates task-row presentation and status validation, and changes user-facing terminology and related test fixtures.

Estimated code review effort: 4 (Complex) | ~60 minutes

Merge Risk: 🟡 Moderate · up to f2dfd

Moving import into a page can leave the task list stale after an uncertain completion and may allow the same source to be imported twice; completion also still opens the imported task rather than preserving the intended catalog-refresh flow. These behaviors should be fixed or explicitly accepted before merge.

Possibly related PRs

• maka-agent/maka-agent#3056: Both changes update restored-task handling in app-shell-session-purge.test.ts.
• maka-agent/maka-agent#3068: Both changes modify restored-session fixtures and purge coverage.

Suggested reviewers: likun666661, zhiiw

🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 19.15% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Ai Use Disclosure	⚠️ Warning	The PR description omits the required AI-use selection, although it discloses “AI-assisted (Claude Code)”; all 20 introduced commits have valid Generated-by: Claude Code trailers.	Select exactly one AI-use declaration, name Claude Code and its scope, and keep the trailers through squash or amend. See CONTRIBUTING.md: Human ownership and AI attribution.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the desktop task-rail rebuild and terminology standardization.
Description check	✅ Passed	The description provides a detailed summary, issue reference, screenshots, verification results, review focus, AI disclosure, checklist, and unrun tests.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 8

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

packages/ui/src/session-history-list.tsx (1)

82-83: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Remove the unused copy binding from SessionHistoryList. It has no references within the component.

Source: Path instructions

🧹 Nitpick comments (3)

packages/ui/src/session-history-list.tsx (1)

697-783: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Use the shared vocabulary for the streaming and unread dots too.

stale resolves its colour through dotForStatus('attention'), while streaming and hasUnread hardcode 'accent'. The stated purpose of this function is that one place turns a status word into a colour. Two of four signals bypass it, so the same drift this change removed can return.

apps/desktop/src/renderer/styles/sidebar.css (1)

327-336: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

On touch devices the timestamp is never visible.

Inside @media (hover: none) the action menu takes the slot and .maka-session-row-time stays visibility: hidden permanently. A sighted touch user therefore loses the row timestamp completely, not just while interacting. Assistive tech still gets the absolute timestamp from the row description, so this is a visible-only gap. Confirm that this is the intended trade for touch, or reserve room for both.

apps/desktop/src/main/chat-readiness.ts (1)

137-137: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Centralize the fake-backend error copy.

The same literal appears in messageForReason and assertSessionCanSend. Define it once and reuse it in both paths. This prevents the two errors from drifting.

Proposed simplification

+const FAKE_BACKEND_MESSAGE =
+  '当前任务来自旧的本地模拟连接，不能直接发送。请到 设置 · 模型 添加真实模型后新建任务。';
+
 function messageForReason(
...
-      return '当前任务来自旧的本地模拟连接，不能直接发送。请到 设置 · 模型 添加真实模型后新建任务。';
+      return FAKE_BACKEND_MESSAGE;
...
-      '当前任务来自旧的本地模拟连接，不能直接发送。请到 设置 · 模型 添加真实模型后新建任务。',
+      FAKE_BACKEND_MESSAGE,

As per path instructions, this is a concrete case where the changed code can be simplified.

Also applies to: 152-152

Source: Path instructions

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c786d305-b1d2-44b2-8db1-a6691f07572f

📥 Commits

Reviewing files that changed from the base of the PR and between 75ea4e7 and cce6cbb.

📒 Files selected for processing (94)

• apps/desktop/e2e/composer-skill-invocation.spec.ts
• apps/desktop/e2e/session-workbar.spec.ts
• apps/desktop/e2e/settings.spec.ts
• apps/desktop/e2e/sidebar-project-row.spec.ts
• apps/desktop/e2e/streaming-remount.spec.ts
• apps/desktop/src/main/__tests__/app-shell-session-purge.test.ts
• apps/desktop/src/main/__tests__/app-shell-session-settings-actions.test.ts
• apps/desktop/src/main/__tests__/bot-incoming-project-cwd.test.ts
• apps/desktop/src/main/__tests__/external-session-import-lifecycle.test.ts
• apps/desktop/src/main/__tests__/runtime-host-external-sessions-ipc-main.test.ts
• apps/desktop/src/main/__tests__/thread-search.test.ts
• apps/desktop/src/main/bot-incoming-main.ts
• apps/desktop/src/main/capability-snapshot.ts
• apps/desktop/src/main/chat-readiness.ts
• apps/desktop/src/main/computer-use/status-item.ts
• apps/desktop/src/main/e2e-fixture/scenarios-sessions.ts
• apps/desktop/src/main/e2e-fixture/scenarios-settings.ts
• apps/desktop/src/main/notifications-policy.ts
• apps/desktop/src/main/runtime-host-external-sessions-ipc-main.ts
• apps/desktop/src/main/search/thread-search.ts
• apps/desktop/src/preload/preload.ts
• apps/desktop/src/renderer/agent-graph-panel.tsx
• apps/desktop/src/renderer/app-shell-chat-actions.ts
• apps/desktop/src/renderer/app-shell-e2e-fixture.ts
• apps/desktop/src/renderer/app-shell-overlays.tsx
• apps/desktop/src/renderer/app-shell.tsx
• apps/desktop/src/renderer/command-palette-commands.ts
• apps/desktop/src/renderer/external-session-import-dialog.tsx
• apps/desktop/src/renderer/external-session-import-lifecycle.ts
• apps/desktop/src/renderer/locales/conversation-copy.ts
• apps/desktop/src/renderer/locales/external-session-import-copy.ts
• apps/desktop/src/renderer/locales/permission-center-copy.ts
• apps/desktop/src/renderer/locales/settings-daily-review-copy.ts
• apps/desktop/src/renderer/locales/settings-data-copy.ts
• apps/desktop/src/renderer/locales/settings-memory-copy.ts
• apps/desktop/src/renderer/locales/settings-navigation-copy.ts
• apps/desktop/src/renderer/locales/settings-preferences-copy.ts
• apps/desktop/src/renderer/locales/settings-projects-copy.ts
• apps/desktop/src/renderer/locales/settings-provider-copy.ts
• apps/desktop/src/renderer/locales/settings-shared-copy.ts
• apps/desktop/src/renderer/locales/settings-subagents-copy.ts
• apps/desktop/src/renderer/locales/settings-usage-copy.ts
• apps/desktop/src/renderer/locales/settings-web-search-copy.ts
• apps/desktop/src/renderer/locales/shell-copy.ts
• apps/desktop/src/renderer/locales/shell-remaining-copy.ts
• apps/desktop/src/renderer/nav-selection.ts
• apps/desktop/src/renderer/session-nav-filter.ts
• apps/desktop/src/renderer/session-status-presentation.ts
• apps/desktop/src/renderer/settings/import-tasks-settings-page.tsx
• apps/desktop/src/renderer/settings/settings-modal.tsx
• apps/desktop/src/renderer/settings/settings-nav.ts
• apps/desktop/src/renderer/settings/settings-surface.tsx
• apps/desktop/src/renderer/styles.css
• apps/desktop/src/renderer/styles/external-session-import.css
• apps/desktop/src/renderer/styles/sidebar.css
• apps/desktop/stories/app-shell.stories.tsx
• apps/desktop/stories/command-search.stories.tsx
• apps/desktop/stories/session-workbar.stories.tsx
• apps/desktop/stories/settings/settings-pages.stories.tsx
• apps/desktop/stories/subagent-sessions.stories.tsx
• docs/astryx-surface-file-inventory.md
• docs/astryx-surface-file-inventory.paths
• packages/cli/src/__tests__/pi-transcript.test.ts
• packages/cli/src/__tests__/pi-tui-runner.test.ts
• packages/cli/src/__tests__/run-session-selection.test.ts
• packages/cli/src/pi-transcript.ts
• packages/cli/src/pi-tui-runner.ts
• packages/cli/src/run-command-core.ts
• packages/core/src/bot-events.ts
• packages/core/src/connection-error-copy.ts
• packages/core/src/session.ts
• packages/core/src/settings.ts
• packages/runtime-host/src/protocol/session-continuity.ts
• packages/runtime-host/src/server/scheduled-task-coordinator.ts
• packages/runtime/src/__tests__/session-manager.test.ts
• packages/runtime/src/session-manager.ts
• packages/ui/src/components.tsx
• packages/ui/src/conversation-copy.ts
• packages/ui/src/daily-review-copy.ts
• packages/ui/src/nav-selection.ts
• packages/ui/src/relative-time.tsx
• packages/ui/src/runtime-resume-copy.ts
• packages/ui/src/scheduled-task-copy.ts
• packages/ui/src/session-history-list.tsx
• packages/ui/src/session-list-panel.tsx
• packages/ui/src/session-rename-dialog.tsx
• packages/ui/src/session-sidebar-nav.tsx
• packages/ui/src/session-status-presentation.ts
• packages/ui/src/shared-ui-copy.ts
• packages/ui/src/shell-controls-copy.ts
• packages/ui/src/tool-activity/copy.ts
• packages/ui/stories/model-picker.stories.tsx
• packages/ui/stories/session-list-panel.stories.tsx
• scripts/check-astryx-alignment.mjs

💤 Files with no reviewable changes (6)

• packages/ui/src/components.tsx
• apps/desktop/src/renderer/external-session-import-lifecycle.ts
• apps/desktop/src/renderer/styles.css
• apps/desktop/src/renderer/styles/external-session-import.css
• apps/desktop/src/renderer/external-session-import-dialog.tsx
• apps/desktop/src/main/tests/external-session-import-lifecycle.test.ts

[Astro-Han]

Covering the four items that were not inline threads — one outside-diff comment and three nitpicks. Three accepted, one declined.

session-history-list.tsx:82-83, unused copy — accepted, e9835cb. Real dead binding, and mine: it fed the list's own aria-label, which the outer SideNav took over when the rail was rebuilt.

session-history-list.tsx:697-783, streaming and unread bypassing the vocabulary — accepted, e9835cb. This is the sharpest of the four. The literals do not just risk drift; a hand-written 'accent' is precisely what let the rail and Settings disagree about the same fact before status-vocabulary.ts existed, which is what this PR set out to close. Both are 'active': streaming is the system working on it, and unread text is "something happened here" rather than a question waiting on the user — the distinction active and attention exist to carry. dotForStatus('active') resolves to 'accent', so nothing moves on screen.

chat-readiness.ts:137,152, duplicated fake-backend copy — accepted, 8e798bf. Extracted to FAKE_BACKEND_MESSAGE. The duplication predates this PR but the argument for fixing it is this PR: renaming 会话 to 任务 had to be applied to the sentence twice, which is the maintenance cost made concrete.

sidebar.css:327-336, timestamp hidden on touch — declined, and it is the intended trade. The comment immediately above that block states it: inside @media (hover: none) nothing can reveal the menu later, so the menu takes the slot outright. Two things bound the cost. Assistive tech is unaffected — the absolute timestamp is in the row description, not the visual slot. And the branch is close to unreachable for this product: hover reflects the primary pointer, so a touchscreen laptop with a mouse reports hover: hover; a Maka desktop build would have to be running on a pure-touch device to hit it. Reserving room for both controls on every row to serve that case would cost the row's two-slot structure, which is the change.

---

Reviewed with CodeRabbit (automated review) and Claude Code (Anthropic). I traced each claim to current source before deciding, and verified the accepted fixes with npm run format, npm run lint, @maka/desktop typecheck across all four tsconfigs, the app-shell-session-purge test file (6/6), and the Storybook render smoke (130 stories). The three declined inline items are answered in their own threads with the code that contradicts them.

[M4n5ter]

English

Approved.

I re-reviewed the updates through e812c2391 against the PR intent. Moving concurrent import coalescing into the Host closes the reported duplicate-import path at the correct ownership boundary, while preserving deliberate repeat imports after completion. The regression coverage pins both behaviors directly.

I also checked the removal of the collapsed rail Tasks row: the unconditional titlebar expand control, retained activeId selection, and session-row navigation provide a complete return path, with E2E coverage. All current checks are green.

简体中文

批准。

我结合本 PR 的真实意图重新审查了截至 e812c2391 的更新。将并发导入合并下沉到 Host，能够在正确的职责边界上修复此前的重复导入问题，同时保留导入完成后主动再次导入的行为；新增回归测试也直接固定了这两项契约。

我还核验了折叠侧栏移除“任务”入口后的返回路径：标题栏展开按钮始终可用，activeId 会保留当前任务标记，点击任务行会切回会话视图，并已有 E2E 覆盖。当前所有检查均已通过。