Skip to content

fix(cu): require observed Electron page identity - #931

Closed
hqhq1025 wants to merge 1 commit into
apache:mainfrom
hqhq1025:codex/cu-page-identity
Closed

fix(cu): require observed Electron page identity#931
hqhq1025 wants to merge 1 commit into
apache:mainfrom
hqhq1025:codex/cu-page-identity

Conversation

@hqhq1025

Copy link
Copy Markdown
Contributor

Summary

  • fail closed when a bound Electron pointer or drag action has no page identity from its observation
  • keep unbound direct backend calls compatible with existing behavior
  • prevent both semantic page dispatch and pixel fallback in the missing-identity case

Verification

  • npm --workspace @maka/computer-use test (128/128 passing)
  • git diff --check

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two mutation paths still bypass the new fail-closed page-identity boundary:

  • P1: middle_click and triple_click do not enter the new Electron page-identity validation and can still reach compatibility pixel dispatch without an observed page identity.
  • P1: When process classification returns unknown, the semantic path returns handled: false before the new check, allowing click/drag to fall back to pixel input.
  • P2: scroll has the same missing identity check, although its impact is lower than pointer clicks.

Please apply the page-identity requirement to every public pointer mutation before any compatibility fallback is selected.

@hqhq1025

Copy link
Copy Markdown
Contributor Author

Superseded by #984, which consolidates #930-#933 into one target-identity boundary and addresses the requested changes. Stable AX token delivery is tracked in trycua/cua#2210.

@hqhq1025 hqhq1025 closed this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants