fix(cu): require observed Electron page identity - #931
Closed
hqhq1025 wants to merge 1 commit into
Closed
Conversation
Astro-Han
requested changes
Jul 14, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Two mutation paths still bypass the new fail-closed page-identity boundary:
- P1:
middle_clickandtriple_clickdo not enter the new Electron page-identity validation and can still reach compatibility pixel dispatch without an observed page identity. - P1: When process classification returns
unknown, the semantic path returnshandled: falsebefore the new check, allowing click/drag to fall back to pixel input. - P2:
scrollhas the same missing identity check, although its impact is lower than pointer clicks.
Please apply the page-identity requirement to every public pointer mutation before any compatibility fallback is selected.
Contributor
Author
|
Superseded by #984, which consolidates #930-#933 into one target-identity boundary and addresses the requested changes. Stable AX token delivery is tracked in trycua/cua#2210. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
npm --workspace @maka/computer-use test(128/128 passing)git diff --check