fix(cu): bind Electron text to clicked element - #933
Closed
hqhq1025 wants to merge 1 commit into
Closed
Conversation
Astro-Han
requested changes
Jul 14, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Two P1 issues remain in the Electron text-target binding:
- P1: The normal new-document path calls
__makaComputerUseReadElementbefore the page helper has been installed, so clicking an empty Electron field and typing can fail before insertion. - P1: The incrementing element token is not bound to a document fingerprint or session. Reloading the same URL can reuse a token for another field, allowing an old session’s text to be inserted into the wrong target and reported as verified.
Please install/read the helper through one consistent path and bind tokens to the document identity plus session, invalidating them on navigation or reload.
This was referenced Jul 14, 2026
Contributor
Author
|
Superseded by #984, which consolidates #930-#933 into one target-identity boundary and addresses the requested changes. Stable AX token delivery is tracked in trycua/cua#2210. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
insert_textThis removes the old type-time
elementFromPointlookup, so same-page layout reflow cannot redirect text to a different field.Verification
@maka/core,@maka/storage, and@maka/runtimeseriallynpm --workspace @maka/computer-use test(128/128 passing)git diff --check