This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Conversation
Contributor
|
Can one of the admins verify this patch? |
ocket8888
suggested changes
Apr 18, 2019
ocket8888
left a comment
Contributor
There was a problem hiding this comment.
Please fill out the Pull Request template to the best of your ability.
mitchell852
suggested changes
Apr 18, 2019
Author
|
Done. |
Member
+1 |
Contributor
|
This was resolved in #3601 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a function has two parameters with the same name, the second parameter shadows the first one, which makes the code hard to understand and error-prone.