This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Removed restangular from AuthService.js - #3601
Merged
mitchell852 merged 2 commits intoJul 26, 2019
Merged
Conversation
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
mitchell852
reviewed
Jun 25, 2019
ocket8888
force-pushed
the
removing-restangular-AuthService
branch
from
June 25, 2019 18:34
5ca1ccd to
3c7c2d8
Compare
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
mitchell852
approved these changes
Jun 26, 2019
mitchell852
left a comment
Member
There was a problem hiding this comment.
ui tests passed
manual tests pass
changes requested were made
ocket8888
force-pushed
the
removing-restangular-AuthService
branch
from
July 23, 2019 15:47
3c7c2d8 to
7a701e6
Compare
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Removes a dependency on Restangular from the "AuthService"
Which Traffic Control components are affected by this PR?
Traffic Portal dependencies are not individually documented, and so no documentation changes are necessary.
What is the best way to verify this PR?
No functionality should have changed (except that errors will now be logged instead of ignored in many cases), so the existing tests should all pass.
Jeremy: actually, the only way to truly verify that the functionality did not change is to:
The following criteria are ALL met by this PR