emrg: tighten bare excepts in _send_shutdown and _stop_daemon - #16
Merged
Conversation
- _send_shutdown: except Exception → (OSError, asyncio.TimeoutError, json.JSONDecodeError, UnicodeDecodeError) - _stop_daemon: except Exception → same Both wrap I/O on the daemon connection (OSError + TimeoutError) plus JSON decoding of the response (JSONDecodeError + UnicodeDecodeError).
argszero
commented
Jul 18, 2026
This was referenced Jul 18, 2026
argszero
commented
Jul 18, 2026
argszero
commented
Jul 18, 2026
This was referenced Jul 18, 2026
argszero
added a commit
that referenced
this pull request
Aug 9, 2026
…T13:16:36) (#596) Carries the emergency Windows v0.2.15 regression hotfix (host observed cmd-window storm + daemon startup failure, had to reboot): - #592: CREATE_NO_WINDOW across all 34 subprocess sites (emrg/_win.py win32_no_window_kwargs) + GUI spawn throttle + scheduler connect backoff - #593: daemon port-file self-heal (_port_keepalive_loop) + G43 PID guard (never delete a live daemon's port file) - #594: TUI spawn throttle (_MAX_SPAWN_ATTEMPTS=3 + reset on connect) - #595: evolution_prompt quick-ref entries Per host authorization (rant #16/#18: release without waiting for real-machine verification), this bump goes straight to Build Release on merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Two remaining bare
except Exceptioninemrg/__main__.pynarrowed to specific types:_send_shutdown(line 139)except Exception → except (OSError, asyncio.TimeoutError, json.JSONDecodeError, UnicodeDecodeError)Wraps:
writer.write/drain(OSError),asyncio.wait_for(reader.readline)(TimeoutError, OSError),json.loads(line.decode())(JSONDecodeError, UnicodeDecodeError)._stop_daemon(line 176)Same exception types. Wraps:
asyncio.run(_get_pid())(same I/O + JSON errors from the inner connect/write/read/decode),os.kill(OSError),cleanup_server(OSError).Verification