emrg: GUI settings panel (6 tabs) + tasks panel (rant 2026-08-13T14:10:14 P2+P3) - #746
Merged
Merged
Conversation
argszero
commented
Aug 13, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle (1/3)
Reviewed the full diff for P2+P3 of the GUI redesign (rant 14:10:14):
- Settings converted from modal to sidebar panel with 6 tabs (model/workdir/github/appearance/language/about) — matches host's approved 6-tab design; content migrated intact (model CRUD, workdir picker, GitHub connect, theme, lang, about + recent); settings-btn + nav icon open the panel; cancel closes.
- Task management relocated into the sidebar tasks panel (
#panel-tasks) replacing both the settings task section and the old tasks-dialog;/triggerno-args opens the panel;openTasksPanel()lazy-loads task meta + renders. - Old
settings-dialog/tasks-dialogremoved — verified no dangling JS references. - New smoke test covers 6-tab switching (independent show/hide, active highlight, invalid-tab guard); task tests + /trigger command test updated to the panel; GUI 233→234.
- Verified locally: 777 pytest + 234 GUI + import + CLI + doc-count guard green; CI test + test-windows PASS (31678136965), mergeStateStatus CLEAN.
argszero
commented
Aug 13, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle (2/3)
Reviewed full diff for P2+P3 (rant 14:10:14):
- Settings dialog → 6-tab settings panel (model/workdir/github/appearance/language/about); tab switching via switchSettingsTab with active highlight + invalid-name guard.
- Task management migrated from settings dialog to the tasks side panel; /trigger no-args now opens the tasks panel (openTasksPanel reuses Dialogs.loadTaskMeta/renderTaskList); showSettings guard prevents double-toggle when nav click already switched the panel.
- index.html restructure is a faithful relocation (no content loss); layout.css self-contained; no stale settings-dialog/tasks-dialog code references remain.
- Tests updated dialog→panel expectations; new P2 tab-switch smoke test; npm test 234/234 pass locally; Agent.md counts synced; doc-count guard green.
- CI test + test-windows SUCCESS (31678136965).
argszero
commented
Aug 13, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle (3/3)
Third independent-cycle approval. Head a389f57 unchanged since the 2/3 review; CI test + test-windows PASS (31678136965), mergeStateStatus CLEAN. P2+P3 of the GUI redesign (rant 14:10:14) — settings panel with 6 tabs + tasks panel, old dialogs removed, GUI 233→234 with the new tab-switch smoke test. Reached 3 consecutive ✅ — merging.
Contributor
|
Post-merge verification + code review of the settings/tasks panel refactor (rant 14:10:14 P2+P3): |
argszero
pushed a commit
that referenced
this pull request
Aug 13, 2026
… entry (#748) Co-authored-by: EMRG Evolution <emrg@argszero.dev>
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GUI redesign (host rant 2026-08-13T14:10:14) — P2 (settings panel) + P3 (tasks panel).
P2 — Settings panel (replaces settings-dialog)
settings-btnand the settings nav icon now open the panel (no more dialog);settings-cancelcloses the panel.App.switchSettingsTab()with active highlight; 6 tab buttons + 6 tab bodies.P3 — Tasks panel (replaces tasks-dialog + settings task management)
#panel-tasks)./triggerwith no args now opens the tasks panel (previously tasks-dialog);openTasksPanel()loads task meta + renders the list on open.settings-dialogandtasks-dialogelements removed entirely.Tests
/triggerapp-commands test asserts panel open.