Skip to content

emrg: GUI settings panel (6 tabs) + tasks panel (rant 2026-08-13T14:10:14 P2+P3) - #746

Merged
argszero merged 1 commit into
masterfrom
feature/gui-settings-tasks-panels
Aug 13, 2026
Merged

emrg: GUI settings panel (6 tabs) + tasks panel (rant 2026-08-13T14:10:14 P2+P3)#746
argszero merged 1 commit into
masterfrom
feature/gui-settings-tasks-panels

Conversation

@argszero

Copy link
Copy Markdown
Owner

GUI redesign (host rant 2026-08-13T14:10:14) — P2 (settings panel) + P3 (tasks panel).

P2 — Settings panel (replaces settings-dialog)

  • Settings converted from a modal dialog into a sidebar panel with 6 tabs: 模型服务 / 工作目录 / GitHub / 外观 / 语言 / 关于 (per host's approved 6-tab design).
  • All content migrated from settings-dialog (model management, workdir picker, GitHub connect, theme, language, about + recent improvements).
  • settings-btn and the settings nav icon now open the panel (no more dialog); settings-cancel closes the panel.
  • Tab switching via App.switchSettingsTab() with active highlight; 6 tab buttons + 6 tab bodies.

P3 — Tasks panel (replaces tasks-dialog + settings task management)

  • Task CRUD + trigger + custom-type management relocated from the settings dialog into the sidebar tasks panel (#panel-tasks).
  • /trigger with no args now opens the tasks panel (previously tasks-dialog); openTasksPanel() loads task meta + renders the list on open.
  • Old settings-dialog and tasks-dialog elements removed entirely.

Tests

  • +1 smoke test: settings 6-tab switching (independent show/hide + active highlight + invalid-tab guard); GUI 233→234 (renderer smoke 111→112).
  • Task-management tests updated to open the tasks panel instead of settings; /trigger app-commands test asserts panel open.
  • 777 pytest + 234 GUI + import + CLI + doc-count guard all green locally.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (1/3)

Reviewed the full diff for P2+P3 of the GUI redesign (rant 14:10:14):

  • Settings converted from modal to sidebar panel with 6 tabs (model/workdir/github/appearance/language/about) — matches host's approved 6-tab design; content migrated intact (model CRUD, workdir picker, GitHub connect, theme, lang, about + recent); settings-btn + nav icon open the panel; cancel closes.
  • Task management relocated into the sidebar tasks panel (#panel-tasks) replacing both the settings task section and the old tasks-dialog; /trigger no-args opens the panel; openTasksPanel() lazy-loads task meta + renders.
  • Old settings-dialog/tasks-dialog removed — verified no dangling JS references.
  • New smoke test covers 6-tab switching (independent show/hide, active highlight, invalid-tab guard); task tests + /trigger command test updated to the panel; GUI 233→234.
  • Verified locally: 777 pytest + 234 GUI + import + CLI + doc-count guard green; CI test + test-windows PASS (31678136965), mergeStateStatus CLEAN.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2/3)

Reviewed full diff for P2+P3 (rant 14:10:14):

  • Settings dialog → 6-tab settings panel (model/workdir/github/appearance/language/about); tab switching via switchSettingsTab with active highlight + invalid-name guard.
  • Task management migrated from settings dialog to the tasks side panel; /trigger no-args now opens the tasks panel (openTasksPanel reuses Dialogs.loadTaskMeta/renderTaskList); showSettings guard prevents double-toggle when nav click already switched the panel.
  • index.html restructure is a faithful relocation (no content loss); layout.css self-contained; no stale settings-dialog/tasks-dialog code references remain.
  • Tests updated dialog→panel expectations; new P2 tab-switch smoke test; npm test 234/234 pass locally; Agent.md counts synced; doc-count guard green.
  • CI test + test-windows SUCCESS (31678136965).

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3)

Third independent-cycle approval. Head a389f57 unchanged since the 2/3 review; CI test + test-windows PASS (31678136965), mergeStateStatus CLEAN. P2+P3 of the GUI redesign (rant 14:10:14) — settings panel with 6 tabs + tasks panel, old dialogs removed, GUI 233→234 with the new tab-switch smoke test. Reached 3 consecutive ✅ — merging.

@argszero
argszero merged commit 09b31dc into master Aug 13, 2026
2 checks passed
@pm25coder

Copy link
Copy Markdown
Contributor

Post-merge verification + code review of the settings/tasks panel refactor (rant 14:10:14 P2+P3):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants