Skip to content

emrg: evolution_prompt quick-ref — add GUI scroll capture fix entry (#764) - #765

Merged
argszero merged 1 commit into
masterfrom
feature/quickref-scroll-capture
Aug 13, 2026
Merged

emrg: evolution_prompt quick-ref — add GUI scroll capture fix entry (#764)#765
argszero merged 1 commit into
masterfrom
feature/quickref-scroll-capture

Conversation

@argszero

Copy link
Copy Markdown
Owner

Summary

Add the implemented-features quick-ref entry for #764 (GUI scroll capture fix) to evolution_prompt.md.

#762 (workspace views) already received its quick-ref entry via #763; #764's regression fix (back-to-bottom + scroll-to-top history load were dead in the real GUI because native scroll events don't bubble past the non-scrolling #workspace wrapper; capture-phase listeners + per-session metrics + scroll-position preservation for existing containers) is a real feature fix and belongs in the quick reference so future cycles recognize it as handled.

Doc-only change (1 line). Verification: pytest 801, import + CLI checks green.

…764)

Document the scroll-capture regression fix (back-to-bottom + scroll-to-top
history load were dead in the real GUI because native scroll events don't
bubble past the non-scrolling #workspace wrapper; capture-phase listeners +
per-session metrics + scroll-position preservation for existing containers).
Merged f46b141.
@pm25coder

Copy link
Copy Markdown
Contributor

I tested this PR (head 459f680) end-to-end and it validates clean:

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — self-review (1/3). Doc-only quick-ref entry for #764 (scroll capture fix); pytest 801 + import + CLI green; CI test + test-windows PASS. Entry accurately documents the regression root cause (scroll doesn't bubble past #workspace) and the fix (capture listeners + per-session metrics + scroll-position preservation).

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (1/3). Quick-ref entry for #764 fact-checked against master f46b141 and my R1454 audit of the actual fix:

  • Root cause accurate: scroll container moved to .session-view (workspace overflow:hidden), native scroll events do NOT bubble → bubble-phase listeners on #workspace never fired (back-to-bottom button never appeared in real GUI, older-history load dead) — regression since #634, hit by #762.
  • Fix details accurate: capture:true listeners + activeScrollEl()/updateBackToBottomState() reading metrics from the active .session-view; back-to-bottom click scrolls the resolved container.
  • activateSessionView scrolls to bottom ONLY for new containers (existed check → scroll position preserved on panel round-trip / session switch, per rant 18:55:09 acceptance).
  • setWorkspaceChrome hides back-to-bottom in panel view, restores by position on return.
  • +1 renderer.smoke regression (GUI 236→237) accurate; merge f46b141 accurate.

No Jinja delimiters; entry placed chronologically after #762 entry; prompt build tests 12/12 pass. CI 31696297334 test+test-windows SUCCESS. MERGEABLE.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3). Fresh verification on head 459f680 (unchanged since 2/3): diff is the single doc-only quick-ref line for #764, fact-checked against master f46b141 (root cause #634 scroll non-bubbling, capture:true fix, activeScrollEl, existed-check scroll preservation, setWorkspaceChrome panel hide/restore, GUI 236→237, merge f46b141 — all accurate); no Jinja delimiters; CI 31696297334 test+test-windows SUCCESS; MERGEABLE. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants