Repository navigation
feat: show read-only local agent runtime in profiles - #220
Conversation
1adf6eb to
d9e935d
Compare
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz>
d9e935d to
ad1d108
Compare
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
No blocking code defects found. Two nonblocking clarity comments inline; this is a COMMENT review, not approval.
Reviewed head ad1d108ece69d7c43b2f2930c881c8f6a0d06604 against base 119195ea331de33c8480bab180df0091ca8e9421, including native projection/custody, exact-key/community selection, profile lifecycle, coalescing and error recovery.
Validation: source review plus hosted CI at merge commit 3f25a496ce0c58d455937f035a53b8a46edf3b59. All 3,317 Vitest tests passed, including the six new runtime tests; Rust/tool integration, browser measurements, both Chromium shards and WebKit 1/2 passed. No local suites or attended native GUI acceptance were run for this review.
Not merge-ready yet: WebKit 2/2 and consequently CI required failed. Failures are the message-navigation reading anchor (59px displacement versus <4px) and narrow Settings at 200% text size (switch viewport ratio 0.99297 versus 1), outside this diff. I have not reproduced them on base or established flakiness. Resolve the required CI gate and obtain maintainer approval before merge.
…olling note The harness/provider/model/workspace rows come from the saved agent view, not the launched configuration, so environment overrides can differ. The summary itself adds no polling but shares the profile actions' existing refresh. Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz>
What changed
Add a read-only Local agent section to the profile Info tab. It is built from the app-owned native
AgentControlsnapshot. It appears only for a record with the exact profile key whose relay origin matches the active community scope (sameCommunityAgents).The section shows:
It never shows environment keys or arguments.
The host error, runtime-unavailable reason, unconfirmed-status notice and Retry status are shown once, by the existing profile actions (feat: add owned local agent actions to profiles #190). The summary shows only facts, so there are no duplicate alerts or Retry buttons.
Browser and unavailable hosts, unknown keys, and records saved for another community render nothing, leaving the public identity. A failed read keeps the last evidence.
Opening the Info tab requests a status read. Concurrent requests coalesce in
AgentControlwith the existing readers. The summary adds no timer of its own; it observes the profile actions' existing 5-second refresh (useAgentControl).docs/profiles.mddocuments the section and the app-wide native custody model: the viewer is not an owner check.Start/Stop/Restart are the separate profile actions from feat: add owned local agent actions to profiles #190. Edit, harness logs and memory stay on Agents.
Verification
At head
f9c31d5onorigin/main119195e:vitest run src/bundled/profiles src/features/agents: 222/222 passed.pnpm typecheckandbiome check docs/profiles.md src/bundled/profiles/: clean.ProfileAgentRuntime.test.tsxcovers:ad1d108: Vitest, Rust/tool integration, browser measurements, both Chromium shards and WebKit 1/2 passed. WebKit 2/2 failedmessage-navigation.spec.mjs:430andsettings.spec.mjs:7, outside this diff. The same two tests also fail WebKit 2/2 on main's own CI run for119195e(run 36063972192).