Skip to content

feat: add owned local agent actions to profiles - #190

Merged
wesbillman merged 6 commits into
mainfrom
cid/profile-agent-actions
Sep 24, 2026
Merged

wesbillman merged 6 commits into
mainfrom
cid/profile-agent-actions

Conversation

@kalvinnchau

@kalvinnchau kalvinnchau commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Changes

  • Add Start, Stop, and Restart to the profile Info tab for one exact locally managed public-key/community match. Ambiguous or foreign identities receive no controls.
  • Reuse the app-owned agent controller and share observation/launch availability with Agents. Preserve pending-operation guards, recovery Stop, and editor dirty-draft gating.
  • Keep admitted commands running across tab changes, preserve keyboard focus, and present one error/retry surface for failed or unconfirmed status.
  • Keep actions isolated from activity, channel membership, and linked-instance navigation. No new editor or destructive actions.

Testing

  • TypeScript, design-system checks, and 289 related unit tests passed.
  • Both complete profile browser suites passed in Chromium and WebKit (12 tests). Two browser scenarios added, none removed: disabled/removed-button focus and pending commands across Info-tab unmount/remount. These cover browser focus behavior beyond jsdom; focus regressions failed before the fixes.
  • Mounted React tests cover exact ownership, ambiguous matches, scope changes, pending commands, failures, and retry recovery. Composed tests cover duplicate-error prevention and unmatched-agent recovery.
  • Captured screenshots and a browser walkthrough of Start → pending → running → rejected Restart → Retry → Stop using a synthetic host.
  • Full frontend suite: 2,862 passed, 12 failed across 10 files outside this change, mostly timeouts. Those failures remain unresolved.

Native renderer-to-process execution, real-agent restart/reconnect, packaged/Windows behavior, and polling performance were not validated. Browser and React checks use a synthetic host.

@kalvinnchau
kalvinnchau force-pushed the cid/profile-agent-actions branch 4 times, most recently from bcfd909 to 564c6f4 Compare September 24, 2026 14:47
cid added 6 commits September 24, 2026 11:00
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
@kalvinnchau
kalvinnchau force-pushed the cid/profile-agent-actions branch from 564c6f4 to ad35c2c Compare September 24, 2026 18:07
@kalvinnchau
kalvinnchau marked this pull request as ready for review September 24, 2026 18:20
@kalvinnchau
kalvinnchau requested review from a team, comp615 and wesbillman as code owners September 24, 2026 18:20

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carl, an automated reviewer, commenting via Wes’s GitHub account.

Ready for approval: no material blockers found. Reviewed head ad35c2cc8003af8e4b109df58740e5925b7a1708 against base 5015556a0b84244b61f3badfd601df4c755d046c, including independent UI and controller review.

  • Exact native identity/community authority, retired-view fencing, pending-command lifetime, recovery Stop, focus/error recovery, and existing Agents/editor gates hold in the reviewed source and regression coverage.
  • Current CI tested merge bce07dc2c30d818665dbf6e82d0f7e6ac274a9e9: all 2,874 Vitest tests across 274 files passed; both new profile browser scenarios passed in Chromium and WebKit. Required checks are green. This supersedes the description’s older 12-failure run as merge evidence, without claiming those local failures were diagnosed. Updating that description would avoid confusion.
  • Remaining limits: synthetic-host tests do not prove live native process/credential handover, restart/reconnect, packaging/Windows behavior or polling performance. No live agents were operated and broad suites were not duplicated locally. These are acceptance limits, not identified defects in this change.

This is a readiness assessment, not an approval submission. Required reviewer approval remains the merge gate.

@wesbillman
wesbillman merged commit 8c075fb into main Sep 24, 2026
12 checks passed
@wesbillman
wesbillman deleted the cid/profile-agent-actions branch September 24, 2026 19:04
morgmart pushed a commit that referenced this pull request Sep 24, 2026
…rs-support

* origin/main:
  feat: show owner-view agent memories in profiles (#231)
  Add opt-in Canvas-backed channel Todos (#222)
  Skip hidden folders when discovering plugins in a folder (#229)
  feat: add owned local agent actions to profiles (#190)
  feat(channels): move session creation into the context menu (#209)
  Add Goose as an agent harness option (#214)
  feat: preview channel agent activity in profiles (#187)
  Use context-aware identity names with human-first priority (#167)
  feat: add managed agents to channels from profiles (#196)

Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>

# Conflicts:
#	src/features/relay/outbox.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants