Conversation
added 2 commits
September 25, 2026 11:43
Other clients can now reproduce the desktop mention chooser and tags from one versioned spec. The spec defines the choice set, query syntax, match tiers, sort order, Space selection, the outside-channel prompt, and the p and two-field mention tags. The JSON fixtures hold literal expected results, and the desktop tests run every case against the production ranking, query, tag writer, and fold code. Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Section 7 now lists Invite, Do nothing, Send anyway, and Close or Escape, with the permission that shows each one, and cites the block/buzz dialog source. Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Contributor
Author
Contributor
Author
|
🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Stacked on #258, which is stacked on #257. Review those first. This PR's diff has only the spec, the fixtures, and the tests that run them.
Summary
What the spec covers
ptag notifies a person (a recipient). A two-fieldmentiontag names a person without notifying them (a reference). This is the same format that other Buzz clients already write. No new event kind or NIP.Details
src/bundled/mentions/README.md, next to the plugin that implements the chooser. This is the same layout as the identity-naming spec (docs(names): specify portable identity disambiguation #227). The README links to it.mention-rules.fixtures.jsonhas 66 cases: ranking (23), Space (12), query syntax (12), multi-word queries (6), tag writing (7), and tag reading (6). The expected outputs are written by hand. The code under test does not generate them.