Ask before mentioning people outside the channel - #257
Conversation
ffe9ca9 to
4ed2a70
Compare
Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
4ed2a70 to
f58b7b7
Compare
The dialog had Cancel and Do nothing, which looked like the same choice. It now shows what block/buzz desktop shows. The text names the people who are not in the channel. The actions are Do nothing and Invite, and Invite shows Inviting… while it runs. Without add permission, the only action is Send anyway. Close and Escape still keep the draft. Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
wesbillman
left a comment
There was a problem hiding this comment.
Star Lord — automated source review via Wes’s account
No actionable introduced defects found in the reviewed diff and supported callers.
- Head:
216a81909210ef006a4d0040e82c366f3cda222d - Base / merge base:
bebcd66e0adb27efa2c320f2bf72b8f3e63a8a45
Traced community-directory selection, captured-draft consent, durable member-add/retry ownership, send cancellation, and reference serialization/rendering. In this app, reference identities remain separate from addressed p recipients; existing membership preflight and notification/wake consumers remain on the addressed path. Rocket’s independent relay/rendering/member-operation source review was reconciled with the integrated pass.
Validation limits: source inspection only, using pinned Git objects with no dirty source inputs. Tests, builds, app workflows, and CI were not run or assessed. Live relay/other-client reference-tag compatibility, browser focus behavior, and native agent execution remain unverified. This is non-blocking COMMENT feedback, not approval or merge authorization.
* origin/main: Explain missing Pi provider models (#263) Browse Goose models and enter provider API keys (#230) test(agents): check model lookup Cancel by visible text (#259) Ask before mentioning people outside the channel (#257) Refine direct message opening (#107) feat(messages): report messages to community moderators (#255) Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>
…-image * origin/main: (23 commits) fix(agents): recover status polling and scope failure diagnostics (#283) Share avatar editing across community profiles and managed agents (#271) feat(profiles): archive, unarchive and delete agents from the profile pane (#256) ci: run browser journeys on three shards per engine (#280) ci: publish scheduled macOS test prereleases (#262) feat: add private text feedback plugin (#242) 🤖 docs: add pre-PR checklist and review guidance to AGENTS.md (#268) perf(sidebar): stop rerendering every row's menu on channel switch (#265) Explain missing Pi provider models (#263) Browse Goose models and enter provider API keys (#230) test(agents): check model lookup Cancel by visible text (#259) Ask before mentioning people outside the channel (#257) Refine direct message opening (#107) feat(messages): report messages to community moderators (#255) perf(channels): stop rerendering message rows after each channel switch (#269) feat(profiles): open targeted agent editor from owner profile (#254) Let plugins declare local commands and HTTPS origins (#169) feat(profiles): show agent metadata and copyable nip05 (#253) Organize app and community settings (#173) Add status badge cutouts to avatars (#211) ...
🤖
Summary
@completion find them in the community directory (the list of everyone in this community).NonMemberMentionDialog.tsx).Screenshots
The chooser marks a person who is not in the channel.
When you send, Buzz asks what to do before it sends. If you can add people, you choose Do nothing or Invite.
If you cannot add people, the only action is Send anyway.
Details
mentiontags, notptags (the tags that trigger notifications). So they show as names but do not notify anyone or wake an agent. Readers add these keys to the message's set of profiles so the names resolve.