Repository navigation
fix(status): reopen a Today status as Today near 16:00 - #275
Merged
Merged
Conversation
loganj
force-pushed
the
larry/status-duration-closest
branch
from
September 25, 2026 18:57
96ea29c to
f0c1608
Compare
The editor infers which duration preset a saved status used by comparing its expiry with each preset's deadline, within two minutes. It took the first match. Around 16:00 the 8-hour deadline is also within two minutes of midnight, so a Today status reopened as 8 hours (and 1 hour near 23:00). Choose the closest preset instead. Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
loganj
force-pushed
the
larry/status-duration-closest
branch
from
September 25, 2026 19:11
f0c1608 to
d5f07c9
Compare
loganj
marked this pull request as ready for review
September 25, 2026 19:31
wesbillman
reviewed
Sep 25, 2026
wesbillman
left a comment
Collaborator
There was a problem hiding this comment.
Star Lord — automated source review via Wes's account
No actionable findings in this change.
Reviewed head d5f07c9bef22b5fffc74a9316b0ac8e3e200687e against base/merge-base 76946a4a6dabec18fd208ef71dcd9c676d970592.
- Traced the nearest-deadline selection through the status editor's initialization and unchanged-expiry preservation, plus the status parsing/save path. On production integer-second timestamps, this retains the existing two-minute tolerance; exact ties preserve preset order, consistent with the documented limitation that the chosen preset is not persisted.
- Inspected the deterministic unit regression cases around the eight-hour and one-hour midnight overlaps, existing editor deadline-preservation coverage, and the unchanged browser reopen assertion. The change stays scoped to preset inference and its unit regression test.
Validation limits: source-only review; pinned source extracts verified and read-only git diff --check passed. No PR code, tests, builds, or app workflows were executed. The PR's reported fail-then-pass/WebKit results were not independently reproduced; CI and runtime acceptance were not assessed. This is a non-blocking COMMENT review, not approval or merge authorization.
wesbillman
approved these changes
Sep 25, 2026
zrmarley
added a commit
that referenced
this pull request
Sep 28, 2026
…ad-on-send * origin/main: (58 commits) Keep profile avatar cutouts transparent and align the header gutter (#319) Restore sidebar status icons beside names (#316) docs(mentions): specify portable mention rules (#343) fix(agents): wait for native host operations (#331) Simplify channel templates and report setup failures accurately (#318) feat(agents): Harnesses Goose install (slice 3/5) (#279) feat(agents): Harnesses status card in Settings (slice 2/5, stacked on #272) (#277) Fix timer operation ownership and stabilize timing regressions (#317) Restore cached workspace before relay startup (#311) test(browser): wait for the app's own quota cooldown before retrying (#284) docs: define Harnesses setup and global agent defaults (#272) Make mention choices consistent and stable (#258) Discover saved relay agents without changing the page (#224) feat: add persistent dev log levels and relay traffic summaries (#306) Polish inline message reactions and previews (#213) feat(identity): add native macOS import, creation and backup (#308) fix(status): reopen a Today status as Today near 16:00 (#275) test: use current navigation for GIF send roundtrip (#309) Fix composer focus when selecting channels and DMs (#307) fix: retire mention searches after chips and refuted prose (#303) ... # Conflicts: # src/features/messages/MessageComposer.test.tsx # src/features/messages/MessageComposer.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
user-status.spec.mjs. The browser tests run in UTC, so any CI run that saved a status between about 15:58 and 16:02 UTC failed withDuration: 8 hours.Details
status-duration.test.tscovers 16:00 and 23:00. It fails on main withExpected "today", Received "28800".