Skip to content

test: use current navigation for GIF send roundtrip - #309

Merged
wesbillman merged 1 commit into
mainfrom
brain/gif-ci-navigation
Sep 25, 2026
Merged

wesbillman merged 1 commit into
mainfrom
brain/gif-ci-navigation

Conversation

@wesbillman

@wesbillman wesbillman commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Authored by Brain on Wes's behalf.

Summary

  • Replace the removed Pages → Messages sidebar selector with the existing openPage(page, "Messages") helper.
  • Test-only repair against main; preserves every GIF publication receipt, attachment rendering, and unexpected-event assertion. No production or identity changes; feat(identity): add native macOS import, creation and backup #308 is unchanged.

Evidence

  • Before: CI run 36197168502 failed this navigation step in both Chromium and WebKit on merge SHA 4168c4364db45d9f0d25ded1f0141d78754b61b5. The stale selector is also present on base d4fa23b07aa7d35be8b88258474e3b4144c22f9f.
  • After: bin/pnpm test:browser tests/browser/gifs.spec.mjs --project chromium --project webkit --no-deps — 8/8 passed, both full GIF files, zero retries, 12.2s Playwright elapsed on macOS. Run used base plus this exact diff; test file SHA-256 b603b274ee27ee7a52af86bf4d7258f3708badfbd461631aea6c405db2f200df.
  • Browser cases added/removed: 0/0. Existing browser integration coverage is unchanged; no replacement coverage or infrastructure changes.
  • Managed security hooks and tracked repository pre-commit/pre-push hooks ran successfully; signed-off commit and remote head verified.

Remaining gates

  • Independent read-only review by Pinky found no blockers at af974dd00b46e7a028ba19d42db1027e6fa3d8f6; necessity, helper behavior, and unchanged assertions were checked. The reviewer did not rerun tests.
  • Hosted DCO passed. Hosted CI completion and explicit human validation remain unverified by this agent. Full repository validation is deferred to CI; this does not certify feat(identity): add native macOS import, creation and backup #308 or a release.
  • Human check: run the browser command above and confirm all eight cases pass.

Originating Buzz channel: 5e3d091d-77b7-4385-872f-59bd8b088393 (implement-identity-setting).

Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
@wesbillman
wesbillman marked this pull request as ready for review September 25, 2026 23:04
@wesbillman
wesbillman requested review from a team and comp615 as code owners September 25, 2026 23:04

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star Lord’s automated source review (via Wes’s account)

No actionable findings. This is a minimal, test-only navigation repair: one existing setup sequence becomes await openPage(page, "Messages").

  • The old Pages sidebar selector is not mounted by the current app composition: App.tsx supplies a sidebar callback that ignores the shell’s page-navigation argument. The existing helper instead uses Search Buzz → Pages → Messages, invokes the same page-selection owner, and waits for the dialog to close.
  • The helper is already imported and used by the other GIF cases. The exact diff preserves the production-broker fixture, publication/event-ID and acceptance-receipt checks, rendered attachment assertions, and unexpected-event assertion. Browser cases added/removed: 0/0. No production behavior, timeouts, retries, or assertion budgets change.

Pinned scope: head af974dd00b46e7a028ba19d42db1027e6fa3d8f6; base/merge-base d4fa23b07aa7d35be8b88258474e3b4144c22f9f. The reviewed test file’s SHA-256 matches the PR’s reported validation input: b603b274ee27ee7a52af86bf4d7258f3708badfbd461631aea6c405db2f200df.

Validation limits: immutable source and relevant navigation callers inspected; extracted bytes verified; git diff --check passed. The author reports 8/8 Chromium/WebKit cases passing on macOS; I did not rerun them. One hosted-check snapshot showed DCO, Semgrep, and zizmor passing, with JavaScript, Rust/tool integration, browser measurements, and all six functional browser shards still running; Windows was skipped. Full CI completion and explicit human acceptance remain unverified. No tests, builds, PR code, app launches, or live-account operations were executed. Non-blocking COMMENT only—not approval, merge authorization, or validation of #308.

@wesbillman
wesbillman merged commit 67fe94c into main Sep 25, 2026
14 checks passed
@wesbillman
wesbillman deleted the brain/gif-ci-navigation branch September 25, 2026 23:17
zrmarley added a commit that referenced this pull request Sep 28, 2026
…ad-on-send

* origin/main: (58 commits)
  Keep profile avatar cutouts transparent and align the header gutter (#319)
  Restore sidebar status icons beside names (#316)
  docs(mentions): specify portable mention rules (#343)
  fix(agents): wait for native host operations (#331)
  Simplify channel templates and report setup failures accurately (#318)
  feat(agents): Harnesses Goose install (slice 3/5) (#279)
  feat(agents): Harnesses status card in Settings (slice 2/5, stacked on #272) (#277)
  Fix timer operation ownership and stabilize timing regressions (#317)
  Restore cached workspace before relay startup (#311)
  test(browser): wait for the app's own quota cooldown before retrying (#284)
  docs: define Harnesses setup and global agent defaults (#272)
  Make mention choices consistent and stable (#258)
  Discover saved relay agents without changing the page (#224)
  feat: add persistent dev log levels and relay traffic summaries (#306)
  Polish inline message reactions and previews (#213)
  feat(identity): add native macOS import, creation and backup (#308)
  fix(status): reopen a Today status as Today near 16:00 (#275)
  test: use current navigation for GIF send roundtrip (#309)
  Fix composer focus when selecting channels and DMs (#307)
  fix: retire mention searches after chips and refuted prose (#303)
  ...

# Conflicts:
#	src/features/messages/MessageComposer.test.tsx
#	src/features/messages/MessageComposer.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants