Use step-ten avatar colors with contrasting outlines - #320
Conversation
Signed-off-by: klopez4212 <klopez4212@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
wesbillman
left a comment
There was a problem hiding this comment.
Star Lord automated source review
Posted through Wes’s account (wesbillman).
No actionable findings in this revision. Source-review assessment: 9/10 for minimalness, elegance, and correctness, within the validation limits below.
- Head:
050386697968b98097bd7b76d791e47f8af7883e - Base:
3e0a4087b9c09df911f080a3c3a3534d5d7bffab
Reviewed all 10 changed files, the shared Avatar/mask composition, representative message/sidebar/profile/agent-picker callers, token consumers, and the contrast/browser assertions. The inset pseudo-element reuses the existing badge geometry and squircle mask without changing the artwork cutout. Offline remains solid; the running-activity pill retains its existing --status-online mapping. In the pinned source snapshot, --status-away has no other production consumer beyond the avatar fill.
Independent arithmetic over the checked-in color literals gives a minimum outline contrast of 3.298:1 across the guard’s listed light/dark opaque surfaces (light Away on --neutral-4). This checks the token pairing, not rendered pixels or blanket WCAG conformance. The mutation tests retain the 3:1 boundary target, and the browser changes extend an existing paint/mask case rather than adding journeys.
Validation limits: source-only review; no PR code, builds, tests, browser/native app, or CI jobs were executed. Snapshot files were verified against the pinned Git blobs; no source edits were made. The PR author reports 68 passing / 4 failing viewer cases involving button and toast/modal focus; those results and baseline attribution were not independently reproduced. Human testing and native runtime validation remain pending as documented in the PR. This COMMENT is not approval, readiness certification, or merge authorization.
Signed-off-by: Codex <codex@openai.com>
wesbillman
left a comment
There was a problem hiding this comment.
Star Lord automated source follow-up
Posted through Wes’s account (wesbillman). No actionable findings; 9/10 for minimalness, elegance, and correctness within this follow-up’s source-only scope.
- Head:
03fd1c948d12ae022729c002ec27b5a3a31eaac8 - Base:
3e0a4087b9c09df911f080a3c3a3534d5d7bffab
Follow-up to the prior review, limited to the actual change since 050386697968b98097bd7b76d791e47f8af7883e: deletion of tests/fixtures/design-system/assets/avatar-status/comparison.png. Complete pinned-tree comparison confirms no other file-content changes. A reference scan across the verified current-tree blobs found no remaining reference to that image. The PR description points to the immutable prior commit; that image remains available there, verified against blob f5e2c23d06200d656aaa529dbf539f6e625fe3e4. The preview source, production behavior, and test assertions are unchanged.
Limits: no PR code, builds, tests, browser/native app, or CI jobs were executed; no live/dirty checkout inputs were used. This does not resolve the author-reported four viewer focus-test failures or establish runtime correctness. Human testing and native validation remain pending. This COMMENT is not approval, readiness certification, or merge authorization.
* origin/main: (45 commits) Use Blue 11 links with Blue 3 hover and explicit contrast exceptions (#322) perf(messages): index the emoji catalog for reaction lookups (#333) Polish search palette and add conversation search (#340) Use step-ten avatar colors with contrasting outlines (#320) Keep profile avatar cutouts transparent and align the header gutter (#319) Restore sidebar status icons beside names (#316) docs(mentions): specify portable mention rules (#343) fix(agents): wait for native host operations (#331) Simplify channel templates and report setup failures accurately (#318) feat(agents): Harnesses Goose install (slice 3/5) (#279) feat(agents): Harnesses status card in Settings (slice 2/5, stacked on #272) (#277) Fix timer operation ownership and stabilize timing regressions (#317) Restore cached workspace before relay startup (#311) test(browser): wait for the app's own quota cooldown before retrying (#284) docs: define Harnesses setup and global agent defaults (#272) Make mention choices consistent and stable (#258) Discover saved relay agents without changing the page (#224) feat: add persistent dev log levels and relay traffic summaries (#306) Polish inline message reactions and previews (#213) feat(identity): add native macOS import, creation and backup (#308) ... Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz> # Conflicts: # src/bundled/agents/AgentCard.tsx # src/bundled/agents/AgentsPage.tsx
* origin/main: (36 commits) Delay message timestamp tooltips by 500 ms (#321) Use Blue 11 links with Blue 3 hover and explicit contrast exceptions (#322) perf(messages): index the emoji catalog for reaction lookups (#333) Polish search palette and add conversation search (#340) Use step-ten avatar colors with contrasting outlines (#320) Keep profile avatar cutouts transparent and align the header gutter (#319) Restore sidebar status icons beside names (#316) docs(mentions): specify portable mention rules (#343) fix(agents): wait for native host operations (#331) Simplify channel templates and report setup failures accurately (#318) feat(agents): Harnesses Goose install (slice 3/5) (#279) feat(agents): Harnesses status card in Settings (slice 2/5, stacked on #272) (#277) Fix timer operation ownership and stabilize timing regressions (#317) Restore cached workspace before relay startup (#311) test(browser): wait for the app's own quota cooldown before retrying (#284) docs: define Harnesses setup and global agent defaults (#272) Make mention choices consistent and stable (#258) Discover saved relay agents without changing the page (#224) feat: add persistent dev log levels and relay traffic summaries (#306) Polish inline message reactions and previews (#213) ... Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz> # Conflicts: # src/bundled/agents/AgentEditor.tsx # src/bundled/profiles/ProfileAgentIdentity.test.tsx
Avatar Online and Away badges now use Green 10 and Amber 10 centers in both themes, with 1px same-hue step-11 outlines that retain the 3:1 boundary contrast target. Avatar sizes, Bézier notches, Offline, text colors, and the non-avatar activity pill stay unchanged. The guard measures the rendered outline and also checks selection/hover surfaces; no thresholds or exemptions were weakened.
Validation at
05038669:Human testing and native runtime validation remain pending.