Delay message timestamp tooltips by 500 ms - #321
Conversation
Signed-off-by: OpenAI Codex <codex@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
wesbillman
left a comment
There was a problem hiding this comment.
Star Lord automated source review (via Wes’s account)
No actionable findings in the reviewed change. Source assessment: minimalness 10/10, elegance 10/10, correctness 9/10, with the validation limits below.
- Head:
8187966692303778f6b886138b3fcb002fd5347c - Base:
3e0a4087b9c09df911f080a3c3a3534d5d7bffab
MessageTimestamp.tsx:45–52 opts both normal and compact timestamps into the existing Base UI hover-delay mechanism and changes only the cursor; the datetime, visible label and full accessible date are retained. Tooltip.tsx:15,23,44 forwards the optional delay and preserves the prior 0 default for other callers. The message-row call sites and other shared-tooltip consumers remain compatible; no feature-owned timer or competing dismissal state is introduced.
I traced the delay, pointer-leave cancellation and disposal paths in Base UI’s v1.8.0 release source, checked the repository’s dependency patch (unrelated form controls), and reviewed the applicable product/design guidance. Repository source inputs were verified against the pinned Git blobs; no live-worktree modifications were used.
Validation limits: This was source-only: no tests, builds, app/browser/native interaction or PR code were executed, and CI was not independently inspected. The existing timestamp tests cover labels/accessibility, not the new elapsed-time contract. Controlled-clock before/after-500-ms and early-leave/unmount coverage, rendered behavior and final human interaction confirmation remain unverified/deferred, as disclosed in the PR. The screenshot is static context, not timing evidence; author-reported passes were not independently reproduced. The dependency trace used the upstream release tag, not an installed package inspection.
This is a non-blocking COMMENT review, not approval, a review-completed attestation, or merge authorization.
Signed-off-by: Codex <codex@openai.com>
* origin/main: (36 commits) Delay message timestamp tooltips by 500 ms (#321) Use Blue 11 links with Blue 3 hover and explicit contrast exceptions (#322) perf(messages): index the emoji catalog for reaction lookups (#333) Polish search palette and add conversation search (#340) Use step-ten avatar colors with contrasting outlines (#320) Keep profile avatar cutouts transparent and align the header gutter (#319) Restore sidebar status icons beside names (#316) docs(mentions): specify portable mention rules (#343) fix(agents): wait for native host operations (#331) Simplify channel templates and report setup failures accurately (#318) feat(agents): Harnesses Goose install (slice 3/5) (#279) feat(agents): Harnesses status card in Settings (slice 2/5, stacked on #272) (#277) Fix timer operation ownership and stabilize timing regressions (#317) Restore cached workspace before relay startup (#311) test(browser): wait for the app's own quota cooldown before retrying (#284) docs: define Harnesses setup and global agent defaults (#272) Make mention choices consistent and stable (#258) Discover saved relay agents without changing the page (#224) feat: add persistent dev log levels and relay traffic summaries (#306) Polish inline message reactions and previews (#213) ... Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz> # Conflicts: # src/bundled/agents/AgentEditor.tsx # src/bundled/profiles/ProfileAgentIdentity.test.tsx
* origin/main: Delay message timestamp tooltips by 500 ms (#321)
* origin/main: Refine presence labels and status colors (#323) Polish media viewers, playback controls, and galleries (#341) perf(mentions): name each choice set once and skip closed choosers (#310) Fix clipped emoji in reaction pills (#339) Delay message timestamp tooltips by 500 ms (#321) Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>
Message timestamp tooltips currently appear immediately while moving across a conversation. Normal and compact continuation timestamps now wait 500 ms before opening and keep the normal arrow cursor. Timestamp text, selection, accessibility, and other tooltip callers retain their existing behavior; Base UI continues to own timing and dismissal.
Validation at
8187966692303778f6b886138b3fcb002fd5347c:cursor: defaultwith text selection stillauto.The user approved the 500 ms behavior and requested this PR ready for review. Explicit final human interaction-test confirmation is not recorded, so the repository's review-completed attestation is intentionally omitted. This does not claim merge readiness.