fix: allow parallel desktop dev worktrees - #336
Conversation
Signed-off-by: Matt Toohey <contact@matttoohey.com>
wesbillman
left a comment
There was a problem hiding this comment.
Star Lord automated source review via Wes's account.
No actionable findings in this six-file change. The guards in src-tauri/src/lib.rs:395–406 and src-tauri/src/deep_links.rs:118–124 use Tauri's development-mode distinction rather than Rust debug assertions. Tauri CLI's build path enables tauri/custom-protocol for debug builds too, preserving packaged/debug single-instance forwarding and registration while ordinary dev skips both. The existing agent-store ownership error is retained in AgentHost state without failing app setup, and shutdown tolerates that failed initialization, consistent with the documented shared-storage limitation.
Reviewed head: 6620436976a4671a58e9c3051d5f9655a4a798e0
Base / merge base: 85d6bf82c54d1c8d930d58444597a1fe31cc8975
Scope: complete diff, launch/build adapters, deep-link plugin initialization/forwarding, AgentHost startup/shutdown, configuration and regression-test source; 19 app source blobs verified against the pinned tree.
Validation limits: source-only; no installs, tests, builds, app launches or OS-handler changes performed. The changed tests are textual source checks, not evidence that parallel windows or packaged warm/cold OS delivery work. Native cross-platform behavior and human acceptance remain unverified. One hosted CI snapshot at 2026-09-28T06:00:41.954Z: JavaScript, Rust/tool integration, browser measurements, all Chromium journey shards, WebKit shard 2/3, DCO and security checks passed; WebKit shards 1/3 and 3/3 were still running; Windows validation was skipped. No wait or polling.
This is non-blocking COMMENT feedback, not approval or merge authorization.
kalvinnchau
left a comment
There was a problem hiding this comment.
🤖 One documentation/test-procedure finding inline; native OS-link behavior remains unverified.
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
wesbillman
left a comment
There was a problem hiding this comment.
Star Lord's automated source review via Wes's account.
No new actionable findings in this bounded follow-up to review 5334564120. The whole-tree delta from the previously reviewed head 6620436976a4671a58e9c3051d5f9655a4a798e0 is limited to docs/deep-links.md; production code and tests are unchanged.
The Windows and Linux instructions now explicitly require rebuilding with just desktop-bundle --no-bundle after ordinary just desktop before testing the shared target/debug executable (docs/deep-links.md:109–130). This addresses the reported rebuild-order gap and matches the launch/build adapters and workspace configuration. The existing handler-ownership safety warning remains intact.
Reviewed head: 19f25a2e405594f154e0c74f26cd70a2413c81d6
Base: 85d6bf82c54d1c8d930d58444597a1fe31cc8975
Scope: documentation delta, unchanged build/dev adapters, workspace/Tauri configuration, deep-link mode guards and test source; 13 immutable app source extracts verified against Git blob hashes, with no dirty worktree inputs. Both PR commits contain DCO sign-off trailers.
Validation limits: source-only; no installs, tests, builds, app launches, PR-code execution or OS-handler changes. Native parallel-window behavior, packaged warm/cold OS-link delivery and human acceptance remain unverified. One exact-head hosted CI snapshot at 2026-09-28T17:38:22Z showed JavaScript, browser measurements, security and DCO checks passing; Rust/tool integration and all six browser journey shards were still running; Windows native validation was skipped. No waiting or polling.
This is non-blocking COMMENT feedback, not approval or merge authorization.
* origin/main: Keep custom emoji animated in reactions (#354) Polish community dialogs, agent cards, and conversation controls (#342) fix(channels): paginate membership discovery beyond 500 channels (#326) Remove local project context from docs (#350) feat(github): render PR descriptions with inline media (#335) feat(dev): measure channel opens, warming cost and live setup (#315) fix(agents): start new agents on Create and make their status clear (#332) fix(macos): close the window without quitting Buzz (#349) fix: allow parallel desktop dev worktrees (#336) feat(relay): complete packaged community access and recovery (#338) fix(workflows): clarify controls and align compact workflow UI (#337) feat: add custom emoji from settings (#346) feat(channels): show typing status on sidebar dm rows (#305) fix(workflows): page batched definition reads (#325) Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz> # Conflicts: # src/bundled/agents/AgentsPage.tsx
Summary
buzz://and forwarding OS deep links.