Skip to content

Polish community dialogs, agent cards, and conversation controls - #342

Merged
mahanti merged 4 commits into
mainfrom
am-buzz-polish-sweep
Sep 28, 2026
Merged

mahanti merged 4 commits into
mainfrom
am-buzz-polish-sweep

Conversation

@mahanti

@mahanti mahanti commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Polish the community, conversation, profile, and agent-library interfaces using the existing design system. Opening formatting or the reaction picker no longer shifts neighboring controls; clipboard feedback appears as a toast instead of inserting a message row.

  • Use the shared community dialog description/footer and inline relay validation.
  • Simplify member search and let its results fill the popover.
  • Align settings/profile header heights, preserve rounded panel edges, and use navigation rows for profile channels.
  • Normalize reply/action capsules and multiline tooltip corners; keep attachment status on one line.
  • Give quick emoji reactions a layout-independent 3× hover scale with random ±10° rotation, respecting reduced motion.
  • Center agent cards around 80 px avatars with balanced spacing, underlined identity popovers, and refresh in the page header.
  • Reduce top-bar icon artwork to the system 20 px size.

Validation

Original polish snapshot: f4591e1; review/CI repair snapshot: af11a14 (current head).

  • Mandatory staged formatting/lint and global sadscan passed.
  • Repository pre-push gates passed: TypeScript, 55 Vitest files / 626 tests, design TypeScript and all design guards. Existing global hook manager preserved; repository gates invoked explicitly with the actual push ref payload.
  • Chromium and WebKit: composer-formats and reactions files passed, including their measurement dependencies (22 tests total).
  • Manually inspected running app: agent cards/identity popover, community inline error, aligned panel headers, formatting toolbar, member picker, and profile navigation in the interactive feedback rounds.

Browser coverage: one new composer geometry case and added assertions in the existing reaction-picker case; no browser cases removed. These check native flex layout, hover transforms, and portaled-picker geometry that jsdom cannot establish. No coverage moved to another layer. Final both-engine pass captured; a fresh fail-before replay was not recorded for this submission.

Screenshots and remaining checks

Six local screenshots and capture notes are saved in the requested Desktop PR Screenshots folder. They show the actual app with the configured community; they are not uploaded to this public PR.

Original hosted CI found stale browser UI assertions and a composer emoji-width regression; these are repaired in af11a14. Hosted CI for the repair and code-owner approval remain pending. Full native builds, packaged-app acceptance, and the complete browser suite were not run locally; existing CI owns broad validation. No auth, protocol, persistence, or native implementation changes.

Review and CI repairs

  • Supply the shared ToastProvider at standalone message fixture roots, including the documented Messages gallery and emoji fixture. No per-row providers.
  • Measure the composer emoji picker against its form instead of the now-positioned formatting group, preserving narrow-pane width.
  • Update browser selectors/assertions for the approved identity popover, channel navigation labels, copy toasts, and capsule reply shape. Focus-ring tests still check all four painted edges; capture bounds include the outward ring of the unbordered list.
  • The eight affected browser files passed 40 existing cases across Chromium/WebKit; the full reactions file then passed all six cases after completing the new gallery regression (42 distinct current cases overall).
  • Added one standalone-gallery browser case for the separate-root/provider/portal boundary, covering copy failure then successful retry. Demonstrated fail-before in Chromium: removing the provider throws the exact Base UI provider-context error. Restoring it passes both engines. No cases removed, no retries/timeouts relaxed, no error allowlist added.
  • Remaining broad coverage is delegated to hosted CI; this does not claim the complete native/browser suite was run locally.

Signed-off-by: Arjun Mahanti <arjun@squareup.com>
@mahanti
mahanti marked this pull request as ready for review September 28, 2026 14:14
@mahanti
mahanti requested review from a team, comp615 and wesbillman as code owners September 28, 2026 14:14
@mahanti

mahanti commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author
01-agent-library 02-agent-identities 03-community-validation 04-aligned-panel-headers 05-composer-formatting 06-member-picker

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star Lord’s automated source review via Wes’s account (wesbillman). Submitted as COMMENT, not approval or Request Changes.

  • Head: f4591e17e7a9f2b8c84dfecae3352aac22f04b79
  • Base: 1d19153276b93ef733fe5e8ead888fc528fc00e3
  • Disposition: one P2 correctness finding inline. The documented standalone Messages gallery lacks the provider newly required by clipboard feedback. This keeps the change below the repository’s 9/10 correctness bar until that caller is repaired; the inline comment gives the smallest fix. No other actionable defect established in the 28-file diff and traced callers.

Review scope and limits: source-only, including a second-frame caller/lifecycle pass. Reviewed pinned Git blobs (84 app/policy/test/context files hash-verified), applicable repository/design guidance, and relevant block/buzz vision documents at ebe99a46e8802b9ff20fdf6a1028ce93bdefaa43. No dirty-worktree source inputs. I did not execute PR code, tests, builds, browser flows, or the app; the finding is source-demonstrated, not runtime-reproduced. Author-reported validation is not reviewer observation.

Remaining validation: the single hosted-check snapshot at this head reports CI required failed, with Chromium and WebKit browser shards 1/3 and 2/3 failed. DCO, JavaScript, Rust/tool integration, browser measurements, both 3/3 browser shards, and security checks succeeded; Windows was skipped. I did not diagnose or attribute those CI failures to this diff. The PR also explicitly lacks fresh fail-before evidence for its browser coverage; explicit human test confirmation is not established by its general manual-inspection statement. Those readiness/validation gaps remain open, separate from the inline defect; this review does not attest buzz-review-completed or merge readiness.

Comment thread src/features/messages/MessageActionBar.tsx
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
@mahanti
mahanti requested a review from wesbillman September 28, 2026 16:08
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
@mahanti
mahanti merged commit 7834fff into main Sep 28, 2026
14 checks passed
@mahanti
mahanti deleted the am-buzz-polish-sweep branch September 28, 2026 18:51
tellaho pushed a commit that referenced this pull request Sep 28, 2026
* origin/main:
  Polish community dialogs, agent cards, and conversation controls (#342)

Signed-off-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz>
johnmatthewtennant pushed a commit that referenced this pull request Sep 29, 2026
* origin/main:
  Keep custom emoji animated in reactions (#354)
  Polish community dialogs, agent cards, and conversation controls (#342)
  fix(channels): paginate membership discovery beyond 500 channels (#326)
  Remove local project context from docs (#350)
  feat(github): render PR descriptions with inline media (#335)
  feat(dev): measure channel opens, warming cost and live setup (#315)
  fix(agents): start new agents on Create and make their status clear (#332)
  fix(macos): close the window without quitting Buzz (#349)
  fix: allow parallel desktop dev worktrees (#336)
  feat(relay): complete packaged community access and recovery (#338)
  fix(workflows): clarify controls and align compact workflow UI (#337)
  feat: add custom emoji from settings (#346)
  feat(channels): show typing status on sidebar dm rows (#305)
  fix(workflows): page batched definition reads (#325)

Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>

# Conflicts:
#	src/bundled/agents/AgentsPage.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants