feat: enable packaged channel writes, encrypted recipes, and direct messages - #436
Conversation
a8ff4ee to
5cd5e8a
Compare
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
One blocking test-code finding below; no additional production correctness/security blocker found across adapter integration, purpose-bound commands, DM opening, and encrypted recipes.
Reviewed head 5cd5e8ae9c0ba20da0eb4b54ebb3122faa72a385 against base/merge base f3fe889eec574a4ecee9b3dfa10697378ef0faa9. Rechecked the rebase delta from a8ff4ee5: the native code, relay adapter, and CI workflow are unchanged, including the three reported lint errors. The prior timeline failures are addressed by the updated base, not defects introduced by this PR.
Validation: source review and existing CI evidence; no local suites rerun by me. Independent recipe review also reports a successful fixture-key NIP-44 interoperability probe, not installed-app acceptance. Current-head CI is still running; previous-head browser results do not establish this head is green. Merge requires the inline repair and passing required CI. Installed native relay operations and OS credential-store restart were not exercised in this review.
wesbillman
left a comment
There was a problem hiding this comment.
No additional source changes requested: the prior test-code finding is repaired, and the current-head Rust job passed. The test-only follow-up preserves rejection assertions and consumes bounded, complete GET headers; independent repair review agrees.
Star Lord’s automated source review via Wes’s account — head 810e50bdea033ff7b55be036b02bef1d65d3127b, base f3fe889eec574a4ecee9b3dfa10697378ef0faa9.
Source-only; no local tests or app execution. CI required remains failed on three browser shards; this review does not establish their cause, packaged-native acceptance, or merge readiness.
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
810e50b to
8b70825
Compare
Summary
Verification