Skip to content

feat: enable packaged channel writes, encrypted recipes, and direct messages - #436

Merged
kalvinnchau merged 3 commits into
mainfrom
am/native-channel-writes
Sep 30, 2026
Merged

kalvinnchau merged 3 commits into
mainfrom
am/native-channel-writes

Conversation

@kalvinnchau

@kalvinnchau kalvinnchau commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add packaged Tauri support for channel lifecycle/details and identity archive writes, encrypted channel recipes, and direct-message opening through purpose-bound native commands.
  • Advertise kind-9007 channel creation only when relay discovery supports NIP-29; enforce own-author and exact-command validation on publication.
  • Register native IPC permissions for the main webview, bound relay discovery reads, and share publish-receipt and recipe validation rules.

Verification

  • Native Rust library suite: 149 passed, 4 ignored; production-context IPC permission and malformed-input checks included.
  • Relay Vitest suite: 86 files, 1,428 tests passed; TypeScript and Biome passed.
  • Pre-push related suite: 81 files, 1,152 tests passed; TypeScript and design-system guards passed.
  • Independent review exercised native IPC and NIP-44 interoperability in both directions using fixture identities.

@kalvinnchau
kalvinnchau marked this pull request as ready for review September 29, 2026 23:31
@kalvinnchau
kalvinnchau requested review from a team, comp615 and wesbillman as code owners September 29, 2026 23:31
@kalvinnchau
kalvinnchau force-pushed the am/native-channel-writes branch from a8ff4ee to 5cd5e8a Compare September 29, 2026 23:48

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carl, an automated reviewer, commenting via Wes’s GitHub account.

One blocking test-code finding below; no additional production correctness/security blocker found across adapter integration, purpose-bound commands, DM opening, and encrypted recipes.

Reviewed head 5cd5e8ae9c0ba20da0eb4b54ebb3122faa72a385 against base/merge base f3fe889eec574a4ecee9b3dfa10697378ef0faa9. Rechecked the rebase delta from a8ff4ee5: the native code, relay adapter, and CI workflow are unchanged, including the three reported lint errors. The prior timeline failures are addressed by the updated base, not defects introduced by this PR.

Validation: source review and existing CI evidence; no local suites rerun by me. Independent recipe review also reports a successful fixture-key NIP-44 interoperability probe, not installed-app acceptance. Current-head CI is still running; previous-head browser results do not establish this head is green. Merge requires the inline repair and passing required CI. Installed native relay operations and OS credential-store restart were not exercised in this review.

Comment thread src-tauri/src/relay/tests.rs Outdated
@kalvinnchau kalvinnchau changed the title Enable packaged channel writes, encrypted recipes, and direct messages feat: enable packaged channel writes, encrypted recipes, and direct messages Sep 29, 2026

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No additional source changes requested: the prior test-code finding is repaired, and the current-head Rust job passed. The test-only follow-up preserves rejection assertions and consumes bounded, complete GET headers; independent repair review agrees.

Star Lord’s automated source review via Wes’s account — head 810e50bdea033ff7b55be036b02bef1d65d3127b, base f3fe889eec574a4ecee9b3dfa10697378ef0faa9.

Source-only; no local tests or app execution. CI required remains failed on three browser shards; this review does not establish their cause, packaged-native acceptance, or merge readiness.

am added 3 commits September 29, 2026 17:40
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
@kalvinnchau
kalvinnchau force-pushed the am/native-channel-writes branch from 810e50b to 8b70825 Compare September 30, 2026 00:45
@kalvinnchau
kalvinnchau merged commit 59e87ce into main Sep 30, 2026
20 checks passed
@kalvinnchau
kalvinnchau deleted the am/native-channel-writes branch September 30, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants