feat: support native read state and recent channel activity - #444
Conversation
ef653a9 to
c26d5bd
Compare
wesbillman
left a comment
There was a problem hiding this comment.
Changes requested:
- P2 — Public contribution metadata: All six commits (
84e74764throughc26d5bda) expose internal deployment/account identifiers in their author/committer contact fields;84e74764ande66690c0also include them in co-author contacts. Use public-safe contribution addresses for those fields while preserving actual am/peon authorship. ValidSigned-off-bytrailers are explicitly exempt; this finding does not request changing them.
No additional production-code defects found after transport/lifecycle tracing and independent native codec/IPC review. The pre-existing stale-pending recovery limitation is already tracked in #447, not a new finding here.
Star Lord automated source review via Wes’s account. Head c26d5bda5ce65069551c2deaf02d4b611318fb44; base e304e3f59aa8ae89a3982d9f144cc933ccaea5b7. No local tests, builds or app execution. The inspected hosted CI snapshot was still running; Windows validation was skipped. Reported human app testing was not independently reproduced.
wesbillman
left a comment
There was a problem hiding this comment.
The existing P2 contribution-metadata finding remains unchanged; valid Signed-off-by trailers remain exempt. No additional production-code defects found in this pass, including the independent native Rust/IPC review; the pre-existing stale-pending limitation stays tracked in #447.
Star Lord automated follow-up via Wes’s account; COMMENT only, not approval. Head c26d5bda5ce65069551c2deaf02d4b611318fb44, base e304e3f59aa8ae89a3982d9f144cc933ccaea5b7: full Vitest 5,447/5,447 passed, typecheck and diff checks passed on a clean worktree. Hosted required CI is green; Windows was skipped, and I did not independently exercise the packaged native workflow or rerun Rust tests locally.
c26d5bd to
1fc4f4f
Compare
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz> Co-authored-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz> Signed-off-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz>
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz> Co-authored-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz> Signed-off-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz>
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
1fc4f4f to
332bc3b
Compare
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
* origin/main: (27 commits) Let plugin pages publish NIP-AR artifacts and embed the host thread view (#434) test(app): migrate entity-navigation test off removed buzz://open locator API (#463) Show agent activity in navigation (#423) test(browser): hold motion when it commits, not on its start event (#459) fix(navigation): ignore unknown query parameters on Buzz links and remove the buzz://open locator (#457) feat(design-system): distinguish controls on floating surfaces (#429) feat(native): add community extras and media preparation (#450) Clone inventory identities through reviewed text and fresh identity creation (#289) feat(communities): add right-click actions to the community rail (#400) fix(messages): keep a send reveal pending until its scroll runs (#454) fix(messages): reserve a stable scrollbar gutter on the channel feed (#451) fix(sidebar): list plugin pages as sidebar rows via an opt-in primary flag (#401) feat(channels): surface canvas content in channel settings (#426) fix(profiles): remove redundant presence status row (#394) test(browser): count live retries once the page handles startup controls (#443) feat(composer): host-owned resource links for the Projects picker (#445) feat: support native read state and recent channel activity (#444) feat(native): serve relay media and uploads in packaged builds (#433) feat(channels): suggest joined channels in the composer (#446) feat: support native agent activity, library, memories, and community resolution (#441) ... Signed-off-by: Codex <noreply@openai.com>
Summary
Validation
maine304e3f5(feat: persist sidebar preferences in packaged desktop #440 sidebar preferences). Conflicts were additive: sidebar and read-state commands, IPC handlers and tests coexist. Read-state Rust code now uses thenostr0.45 import paths from feat: persist sidebar preferences in packaged desktop #440 (Keys,NostrSecretKey,Event).c26d5bda: types and related unit tests, design system, Rust Clippy.cargo test --offline --locked -p buzz-foundation -- --test-threads=1: 164 passed, 4 ignored, plus 1 integration test. A parallel run hit the two knownhost_commandtiming flakes.vitest run src/features/relay/: 87 files / 1,445 tests passed.git diff --check origin/main..HEADpassed.Review and readiness
ef653a95, including the feat: enable packaged channel writes, encrypted recipes, and direct messages #436 overlap. The feat: persist sidebar preferences in packaged desktop #440 conflict resolution on top of it has not been re-reviewed by those lanes.buzz-review-completed