test(app): migrate entity-navigation test off removed buzz://open locator API - #463
Merged
Merged
Conversation
…ator API PR #457 removed bindSharedTarget, parseTargetLink, and targetLink from features/navigation/targets but missed this test file, breaking typecheck on main. Apply the same parseOpenTarget migration used by the other callers. Signed-off-by: Kalvin Chau <kalvin@block.xyz>
kalvinnchau
marked this pull request as ready for review
September 30, 2026 17:30
kalvinnchau
requested review from
a team,
comp615 and
wesbillman
as code owners
September 30, 2026 17:30
wpfleger96
approved these changes
Sep 30, 2026
kalvinnchau
deleted the
fix/entity-navigation-test-targets-migration
branch
September 30, 2026 17:48
This was referenced Sep 30, 2026
TheSentinel454
pushed a commit
that referenced
this pull request
Sep 30, 2026
* origin/main: (27 commits) Let plugin pages publish NIP-AR artifacts and embed the host thread view (#434) test(app): migrate entity-navigation test off removed buzz://open locator API (#463) Show agent activity in navigation (#423) test(browser): hold motion when it commits, not on its start event (#459) fix(navigation): ignore unknown query parameters on Buzz links and remove the buzz://open locator (#457) feat(design-system): distinguish controls on floating surfaces (#429) feat(native): add community extras and media preparation (#450) Clone inventory identities through reviewed text and fresh identity creation (#289) feat(communities): add right-click actions to the community rail (#400) fix(messages): keep a send reveal pending until its scroll runs (#454) fix(messages): reserve a stable scrollbar gutter on the channel feed (#451) fix(sidebar): list plugin pages as sidebar rows via an opt-in primary flag (#401) feat(channels): surface canvas content in channel settings (#426) fix(profiles): remove redundant presence status row (#394) test(browser): count live retries once the page handles startup controls (#443) feat(composer): host-owned resource links for the Projects picker (#445) feat: support native read state and recent channel activity (#444) feat(native): serve relay media and uploads in packaged builds (#433) feat(channels): suggest joined channels in the composer (#446) feat: support native agent activity, library, memories, and community resolution (#441) ... Signed-off-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR #457 removed the
buzz://openlocator API (bindSharedTarget,parseTargetLink,targetLink) fromfeatures/navigation/targetsbut missedsrc/app/entity-navigation.test.tsx, which still imported them — breakingpnpm typecheckon main. This applies the sameparseOpenTargetmigration #457 used intargets.test.tsand other callers.Changes
src/app/entity-navigation.test.tsx:18: importparseOpenTargetinstead of the deleted functionssrc/app/entity-navigation.test.tsx:414:bindSharedTarget(parseTargetLink(targetLink(old)), viewer)→parseOpenTarget(old)(a validation no-op now that the shared-locator unbinding step is gone by design)Validation
pnpm typecheck,pnpm design:typecheck,pnpm design:check— cleanbiome checkon the changed file — cleanvitest run src/app/entity-navigation.test.tsx— 6/6 passed (7.8s)Checklist
targets.test.ts