perf(native): reduce crypto, upload and discovery overhead - #464
Merged
Merged
Conversation
Signed-off-by: peon1 <1165c42e2b72410b51357edfe5b97f04db028a592e1c713cc1abbdd2d9b9940c@buzz.block.builderlab.xyz> Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
Retain peon1’s batch memory decoder and add the complementary ciphertext tamper regression. Exclude gzip transport and dependency changes. Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
kalvinnchau
marked this pull request as ready for review
September 30, 2026 17:52
kalvinnchau
requested review from
a team,
comp615 and
wesbillman
as code owners
September 30, 2026 17:52
wesbillman
reviewed
Sep 30, 2026
wesbillman
left a comment
Collaborator
There was a problem hiding this comment.
No changes requested. Star Lord’s automated source review via Wes’s account, including independent crypto review, found no concrete introduced defects across batch decryption, upload hashing, parallel discovery, or GIF cache recovery at head 65ebde248523f9b85991a119a955d29cea676180 against base bfe4c7f1832935ef5a4c93e11ba4725baac4b728. Hosted CI and DCO passed in the checked snapshot; Windows native validation was skipped. Source-only: no local tests or packaged-app workflow exercised; this comment is not approval.
wesbillman
approved these changes
Sep 30, 2026
cynfria
pushed a commit
that referenced
this pull request
Sep 30, 2026
…followup * origin/main: fix(sidebar): save channel moves on desktop and move channels by drag (#474) perf(messages): stop re-rendering every row on each channel-list publish (#473) Unify workspace panels and add persistent channel tabs (#413) ci: prune expired preview releases after promotion (#461) feat(sidebar): show unread conversation counts and DM avatar previews (#472) fix(previews): dismiss hovered previews when their trigger scrolls (#460) perf(native): reduce crypto, upload and discovery overhead (#464) Signed-off-by: Tree Trunks <6ba22921d9dc2ad0aa6ecdf63787ddd24726e266d866da31af69f2e4e146ace5@buzz.block.builderlab.xyz> # Conflicts: # src/shared/design-system/icons/index.ts # tests/browser/layout.spec.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
At head
65ebde248523f9b85991a119a955d29cea676180, rebased ontobfe4c7f1:git diff --checkpassed.Earlier combined candidate
a699e876passed the full frontend suite (5,693 tests) and native suite (195 unit tests + one integration test; six ignored), with independent static, security and integration reviews. These earlier results are not attributed to the rebased head. The sole reported GIF cache finding is repaired by the third commit.