feat(sidebar): show unread conversation counts and DM avatar previews - #472
Merged
Merged
Conversation
added 2 commits
September 30, 2026 13:56
Signed-off-by: Carl <32a2e2c9d428ee08902cab75d956da2c1d235a22d4766b0dd4138bf6e2e5db1d@buzz.block.builderlab.xyz>
Signed-off-by: Carl <32a2e2c9d428ee08902cab75d956da2c1d235a22d4766b0dd4138bf6e2e5db1d@buzz.block.builderlab.xyz>
wesbillman
marked this pull request as ready for review
September 30, 2026 21:21
kalvinnchau
approved these changes
Sep 30, 2026
wesbillman
commented
Sep 30, 2026
wesbillman
left a comment
Collaborator
Author
There was a problem hiding this comment.
No changes requested. The distinct conversation counts, one-to-one DM previews and nearest-row reveal behavior match the documented contract without adding unread subscriptions or read-state writes.
Star Lord automated source review via Wes’s account — head a637fdbcdcee51778bc8d127234883676079dcc4; base 61d0bd57e097aae8755d306f6228ef76404056b4. Source-only: no tests or app execution; the hosted CI snapshot passed its required check, but the final human visual check and native behavior remain unverified.
cynfria
pushed a commit
that referenced
this pull request
Sep 30, 2026
…followup * origin/main: fix(sidebar): save channel moves on desktop and move channels by drag (#474) perf(messages): stop re-rendering every row on each channel-list publish (#473) Unify workspace panels and add persistent channel tabs (#413) ci: prune expired preview releases after promotion (#461) feat(sidebar): show unread conversation counts and DM avatar previews (#472) fix(previews): dismiss hovered previews when their trigger scrolls (#460) perf(native): reduce crypto, upload and discovery overhead (#464) Signed-off-by: Tree Trunks <6ba22921d9dc2ad0aa6ecdf63787ddd24726e266d866da31af69f2e4e146ace5@buzz.block.builderlab.xyz> # Conflicts: # src/shared/design-system/icons/index.ts # tests/browser/layout.spec.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
N unreaddistinct offscreen conversations and up to three overlapping 1:1 DM avatars in both sidebar directions.Validation
a637fdbcdcee51778bc8d127234883676079dcc4, the pre-push organization guard, TypeScript, related Vitest tests (7 files / 68 tests), and design-system checks passed. The Rust lane correctly skipped unchanged Rust inputs.61d0bd57): the two commits since this branch’s base (32cc8c13) touch inventory UI and reload shortcuts, not the changed sidebar/fixture paths. Hosted merge checks remain pending.Test-layer rationale
One browser case added per engine, none removed: production sidebar wiring, clipping/scroll direction, 20px avatar geometry, overlap, and computed circle/squircle styling need real layout. The original broad CSS selector failed the avatar-padding assertion in both engines; the corrected shared-button recipe passes. Nine colocated component cases cover count deduplication, visible-copy suppression, avatar caps/order, fallback/profile refresh, removal, and unchanged nearest-row activation.
Remaining readiness gate
Draft pending a final human visual check. The earlier preview was approved, but the subsequent CSS correction changed the pill to shared-button capsule corners and symmetric 16px horizontal padding. Recheck both above/below pills while scrolling unread DMs; clicking must reveal/focus the nearest unread row without opening or marking it read. No preview server was restarted for delivery. Full hosted CI and native validation remain outstanding.