Skip to content

fix(media): pause video only on comment composer focus - #483

Merged
wesbillman merged 1 commit into
mainfrom
comment-at-current-frame-pauses
Oct 1, 2026
Merged

wesbillman merged 1 commit into
mainfrom
comment-at-current-frame-pauses

Conversation

@matt2e

@matt2e matt2e commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Clicking on things in the comment thread keep pausing the video. Old Buzz just did this for the composer. I'm changing it back to that behaviour, but I'm not 100% liking that behaviour either.

Summary

  • Pause review videos only when focus enters the comment composer, not when toggling “Comment at current frame” or selecting a timestamped reply.
  • Preserve the composer layout with a display-contents wrapper.
  • Add regression coverage for pointer and keyboard focus and timestamp reply playback.

🤖 Generated with Claude Code

Move the focus-capture pause handler from the comments sidebar to a composer-only wrapper while preserving the sidebar layout. Leave checkbox and timecode interactions free of unintended pauses, and cover pointer and keyboard composer focus with regression tests.

Signed-off-by: Matt Toohey <contact@matttoohey.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
@matt2e
matt2e requested review from a team, comp615 and wesbillman as code owners October 1, 2026 02:22

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable changes requested. The narrower focus-capture boundary excludes checkbox and timestamp controls while preserving composer focus handling.

Star Lord automated source review via Wes’s account: head fc6d8ca5934f4e0507211dce6b623cbd1e3870e3, base 1a692d5d849145376be899fe0ecf7af195e3527c. Source-only: tests/app not run and CI not checked; native focus, playback, and layout remain unverified.

@wesbillman
wesbillman merged commit 3daddd3 into main Oct 1, 2026
21 checks passed
@wesbillman
wesbillman deleted the comment-at-current-frame-pauses branch October 1, 2026 14:00
johnmatthewtennant added a commit that referenced this pull request Oct 1, 2026
* origin/main: (82 commits)
  Test provider connections before model selection (#500)
  Bundle Goose ACP with Buzz (#497)
  Discover saved identities across joined communities with names, pictures and retry (#291)
  Clarify design-system documentation and unify component examples (#498)
  feat(composer): convert typed Markdown live and refuse control characters committed as text (#455)
  fix(messages): stop three timeline scroll races that flake CI (#456)
  Improve Agent defaults pickers and provider keys (#392)
  fix(threads): keep thread history painted after scroll corrections (#493)
  feat(plugins): expose the agent protection service (#421)
  perf(sidebar): re-render only the changed row on a channel-list publish (#480)
  feat(agents): copy protection defaults into new agents (#420)
  feat(agents): support native launch protection providers (#415)
  fix(composer): prevent WebKit overpainting mention selections (#490)
  fix(composer): prevent arrow keys from inserting control characters (#488)
  perf(channels): fall back to one exact roster read when confirming agent adds (#485)
  fix(media): pause video only on comment composer focus (#483)
  fix(channels): dismiss management modals with outside clicks (#479)
  perf: reuse message date formats and stable reaction shortcuts (#477)
  feat(profile): run an unattended scenario file in web profiling (#476)
  feat(channels): administer channel members and roles (#453)
  ...

Signed-off-by: John Tennant <jtennant@block.xyz>

# Conflicts:
#	src/app/shell/usePanelLauncher.ts
#	src/bundled/agents/AgentsPage.tsx
#	src/bundled/agents/InventoryIdentityCard.tsx
#	src/bundled/agents/InventoryView.tsx
#	src/bundled/agents/UnifiedInventory.tsx
#	src/bundled/agents/index.tsx
johnmatthewtennant pushed a commit that referenced this pull request Oct 1, 2026
* origin/main: (82 commits)
  Test provider connections before model selection (#500)
  Bundle Goose ACP with Buzz (#497)
  Discover saved identities across joined communities with names, pictures and retry (#291)
  Clarify design-system documentation and unify component examples (#498)
  feat(composer): convert typed Markdown live and refuse control characters committed as text (#455)
  fix(messages): stop three timeline scroll races that flake CI (#456)
  Improve Agent defaults pickers and provider keys (#392)
  fix(threads): keep thread history painted after scroll corrections (#493)
  feat(plugins): expose the agent protection service (#421)
  perf(sidebar): re-render only the changed row on a channel-list publish (#480)
  feat(agents): copy protection defaults into new agents (#420)
  feat(agents): support native launch protection providers (#415)
  fix(composer): prevent WebKit overpainting mention selections (#490)
  fix(composer): prevent arrow keys from inserting control characters (#488)
  perf(channels): fall back to one exact roster read when confirming agent adds (#485)
  fix(media): pause video only on comment composer focus (#483)
  fix(channels): dismiss management modals with outside clicks (#479)
  perf: reuse message date formats and stable reaction shortcuts (#477)
  feat(profile): run an unattended scenario file in web profiling (#476)
  feat(channels): administer channel members and roles (#453)
  ...

Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>

# Conflicts:
#	src/app/shell/usePanelLauncher.ts
#	src/bundled/agents/AgentsPage.tsx
#	src/bundled/agents/InventoryIdentityCard.tsx
#	src/bundled/agents/InventoryView.tsx
#	src/bundled/agents/UnifiedInventory.tsx
#	src/bundled/agents/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants