Conversation
fe13e27 to
495ddef
Compare
2c38bfc to
d443bc7
Compare
495ddef to
883e818
Compare
…res and retry Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
d443bc7 to
d57b648
Compare
883e818 to
3c77606
Compare
wesbillman
left a comment
There was a problem hiding this comment.
Star Lord automated source review
Posted via Wes’s wesbillman account. One actionable P2 finding, inline: configured community aliases cause the Agents inventory render to fail.
Reviewed head d57b648a7f8b00a6fada8e1d769762a0dcaf751f against base 3c7760618bd033d6dacc75a0dc365557a7128dc3 (26 changed files). The review traced joined-membership discovery, viewer/selection changes, retry/cancellation, inventory/profile reads, naming/media handling, and the supported callers and test source. This review concerns this PR’s delta; it does not clear or repeat findings inherited from the stacked base.
Validation limits: source inspection only. No PR code, tests, builds, browser/native app workflows, credential operations, or CI checks were run. The alias failure is established from the supported membership contract and render call path, not a runtime reproduction. This is a nonblocking COMMENT, not approval or merge authorization.
Signed-off-by: klopez4212 <klopez4212@gmail.com>
wesbillman
left a comment
There was a problem hiding this comment.
Star Lord automated source review — focused follow-up
Posted via Wes’s wesbillman account. The prior P2 is addressed in source; no new actionable findings in the fix.
Reviewed head 40719c101c01b3737ffd3f36c44bc53d1eabda28 against base 3c7760618bd033d6dacc75a0dc365557a7128dc3. Following AGENTS.md’s follow-up policy, this review checks the two-file change since reviewed head d57b648a7f8b00a6fada8e1d769762a0dcaf751f, the prior finding, and supported callers/contracts—not a fresh clearance of the stacked feature.
src/bundled/agents/use-community-inventory.ts:30now resolves membership IDs throughcommunityDestination(m.id).urlbefore origin deduplication. That supports configured aliases while preserving the canonical origins used for discovery, addressing the render failure reported in the prior P2.- The mounted regression at
src/bundled/agents/UnifiedInventory.test.tsx:335–367uses the real destination parser with an explicit alias mapping. Its assertions cover an unselected alias plus the equivalent URL, one canonical inventory request, and unchanged membership ID/selection. I inspected this test’s source; I did not execute it.
Validation limits: source inspection only, using hash-verified files pinned to the reviewed head. No PR code, tests, builds, browser/native workflows, or CI checks were run; no runtime or fail-before/pass-after result is claimed. This is a nonblocking COMMENT, not approval or merge authorization, and does not clear findings inherited from other stacked PRs.
🤖
Summary
Details