Skip to content

Discover saved identities across joined communities with names, pictures and retry - #291

Open
loganj wants to merge 2 commits into
feat/inventory-community-rowsfrom
feat/inventory-joined-discovery
Open

loganj wants to merge 2 commits into
feat/inventory-community-rowsfrom
feat/inventory-joined-discovery

Conversation

@loganj

@loganj loganj commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

🤖

Summary

  • The inventory now finds saved identities in every community you have joined, not only the selected one. It shows their names and profile pictures.
  • If one community cannot be read, it shows its own warning with a Refresh agents retry. Results from the other communities stay visible.

Details

  • Each community is read in its own scope. Discovery does not select that community or open a relay session for it.
  • Each exact key appears once, with all of its known communities.
  • Names and pictures come from the community that supplied the identity.
  • Discovery provides no credentials and no import source. It cannot extend a local identity into another community.
  • Based on Group inventory by community and use compact rows outside the current community #290.

@loganj
loganj force-pushed the feat/inventory-community-rows branch from fe13e27 to 495ddef Compare September 25, 2026 19:38
@loganj
loganj force-pushed the feat/inventory-joined-discovery branch 2 times, most recently from 2c38bfc to d443bc7 Compare September 26, 2026 15:06
@loganj
loganj force-pushed the feat/inventory-community-rows branch from 495ddef to 883e818 Compare September 26, 2026 15:06
@loganj
loganj marked this pull request as ready for review September 26, 2026 15:11
@loganj
loganj requested review from a team, comp615 and wesbillman as code owners September 26, 2026 15:11
…res and retry

Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
@loganj
loganj force-pushed the feat/inventory-joined-discovery branch from d443bc7 to d57b648 Compare September 26, 2026 15:45
@loganj
loganj force-pushed the feat/inventory-community-rows branch from 883e818 to 3c77606 Compare September 26, 2026 15:45

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star Lord automated source review

Posted via Wes’s wesbillman account. One actionable P2 finding, inline: configured community aliases cause the Agents inventory render to fail.

Reviewed head d57b648a7f8b00a6fada8e1d769762a0dcaf751f against base 3c7760618bd033d6dacc75a0dc365557a7128dc3 (26 changed files). The review traced joined-membership discovery, viewer/selection changes, retry/cancellation, inventory/profile reads, naming/media handling, and the supported callers and test source. This review concerns this PR’s delta; it does not clear or repeat findings inherited from the stacked base.

Validation limits: source inspection only. No PR code, tests, builds, browser/native app workflows, credential operations, or CI checks were run. The alias failure is established from the supported membership contract and render call path, not a runtime reproduction. This is a nonblocking COMMENT, not approval or merge authorization.

Comment thread src/bundled/agents/use-community-inventory.ts Outdated
Signed-off-by: klopez4212 <klopez4212@gmail.com>

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star Lord automated source review — focused follow-up

Posted via Wes’s wesbillman account. The prior P2 is addressed in source; no new actionable findings in the fix.

Reviewed head 40719c101c01b3737ffd3f36c44bc53d1eabda28 against base 3c7760618bd033d6dacc75a0dc365557a7128dc3. Following AGENTS.md’s follow-up policy, this review checks the two-file change since reviewed head d57b648a7f8b00a6fada8e1d769762a0dcaf751f, the prior finding, and supported callers/contracts—not a fresh clearance of the stacked feature.

  • src/bundled/agents/use-community-inventory.ts:30 now resolves membership IDs through communityDestination(m.id).url before origin deduplication. That supports configured aliases while preserving the canonical origins used for discovery, addressing the render failure reported in the prior P2.
  • The mounted regression at src/bundled/agents/UnifiedInventory.test.tsx:335–367 uses the real destination parser with an explicit alias mapping. Its assertions cover an unselected alias plus the equivalent URL, one canonical inventory request, and unchanged membership ID/selection. I inspected this test’s source; I did not execute it.

Validation limits: source inspection only, using hash-verified files pinned to the reviewed head. No PR code, tests, builds, browser/native workflows, or CI checks were run; no runtime or fail-before/pass-after result is claimed. This is a nonblocking COMMENT, not approval or merge authorization, and does not clear findings inherited from other stacked PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants