Skip to content

fix(build): pin Rust 1.98.1 to unblock macOS 27 agent builds - #529

Merged
wesbillman merged 1 commit into
mainfrom
upgrade-rust
Oct 2, 2026
Merged

wesbillman merged 1 commit into
mainfrom
upgrade-rust

Conversation

@matt2e

@matt2e matt2e commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade the Hermit Rust pin and tool symlinks from 1.97.1 to 1.98.1, fixing stripped proc-macro loading failures (mis-aligned LINKEDIT string pool) during Goose agent-runtime builds on macOS 27. See rust-lang/rust#157750.
  • Adopt the new Clippy as_chunks suggestion in secret parsing without changing behavior.
  • Update the documented toolchain version; Windows CI already derives it from the Hermit package filename.

Validation

  • Hosted Linux CI, security checks, and DCO Check pass at 9c1d1288; git diff --check passes.
  • No additional local builds/tests run for this PR update. macOS 27 runtime-build acceptance, Windows validation, agent review, and human confirmation remain unverified in this session.

🤖 Generated with Claude Code

Building the Goose agent runtime on macOS 27 failed loading the stripped
sqlx proc-macro: "mis-aligned LINKEDIT string pool". The llvm-objcopy
bundled with Rust <= 1.97 does not 8-byte align the Mach-O string table
when stripping, and macOS 27's dyld now rejects such dylibs on dlopen.
Goose's `lean` profile strips symbols, which Cargo applies to proc-macros
too. Fixed upstream by rust-lang/rust#158410 (Rust 1.98.0), see
rust-lang/rust#157750.

Bump the Hermit pin to 1.98.1 and adopt the one new Clippy suggestion
(`chunks_exact_to_as_chunks`) it raises. Windows CI reads the pin from
the `bin/.rust-*.pkg` filename, so no workflow change is needed.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
@matt2e
matt2e marked this pull request as ready for review October 2, 2026 04:18
@matt2e
matt2e requested review from a team, comp615 and wesbillman as code owners October 2, 2026 04:18

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes requested. The Rust tool symlinks consistently select 1.98.1, the inspected build/CI consumers use that pin, and the guarded 64-byte hex-parser change preserves decoding and identity validation.

Star Lord’s automated source review via Wes’s account; head 9c1d1288fe729d7df1b4cd4492b99aaee56d9509, base 75e6dc396431f188901b671975a9d4d3ae9f5599. Source-only: no builds/tests or macOS 27 reproduction performed; the CI snapshot was incomplete, and native/cross-platform runtime behavior remains unverified.

@matt2e matt2e changed the title Pin Rust 1.98.1 so the agent runtime builds on macOS 27 fix(build): pin Rust 1.98.1 to unblock macOS 27 agent builds Oct 2, 2026
@wesbillman
wesbillman merged commit 5684bb8 into main Oct 2, 2026
22 checks passed
@wesbillman
wesbillman deleted the upgrade-rust branch October 2, 2026 17:55
johnmatthewtennant pushed a commit that referenced this pull request Oct 2, 2026
* origin/main: (21 commits)
  Add remote agent owner attestation fn to host service (#532)
  fix(build): pin Rust 1.98.1 to unblock macOS 27 agent builds (#529)
  main fix: Pi model test ETXTBSY flake (#513)
  fix(composer): remove phantom text-field focus outlines (#519)
  fix(relay): use writer reads for channel confirmations (#501)
  feat(channels): unify header actions and inline details editing (#487)
  Show app-managed agents working in the sidebar (#539)
  Add recoverable hosted community deletion (#403)
  Add verified Inbox evidence and exact edit closure (#495)
  Animate Buzz startup through initial content readiness (#534)
  Polish profile avatar picker and custom colors (#533)
  Add Send to channel for authored thread replies (#531)
  Allow plugins to send managed-agent registration events (kind 30177) (#535)
  Fix Pi and Goose environment overrides (#517)
  feat(ui): Switch shared icons to Tabler (#523)
  Improve message media contrast and thumbnail fill (#521)
  Document unified inventory and verify focused import and compact-row acceptance (#293)
  fix(ux): clarify Pi installation and setup errors (#511)
  Count unread replies only in conversations you are part of (#471)
  Animate the terminal welcome with a compact hex wordmark (#508)
  ...

Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants