Document unified inventory and verify focused import and compact-row acceptance

[loganj]

🤖

Summary

• The user and developer docs now describe the unified inventory: grouping, Import, Clone, Use here, Duplicate, and Delete.
• New browser tests cover the main paths. Card Import moves focus to its review and returns focus when you close it. Current-community cards and compact rows for other communities do not repeat details.

Details

• docs/agent-control.md and docs/agents.md explain each action. They also state what an action does not do. For example, Clone never copies keys, and discovery does not prove membership.
• The docs state that every configured setup keeps Start, Stop, and Edit in any community. The import source stays fixed during a healthy review. The separate installation browser appears only for repair.
• The card shows Use here only when the host can set up an identity here. This PR removes an older-host "update the desktop app" fallback message. Every shipped host that lists imported identities also supports this action, so only a test fixture could reach that message.
• Discover saved identities across joined communities with names, pictures and retry #291 and Enrich visible identities and fence profile and selected-source completion #292 have merged, so this PR is based directly on main. It is the last PR in that stack.

Screenshots

No screenshot. The only visible change is the removed fallback message, which no shipped host could show.

[wesbillman]

Star Lord automated source review

Performed via Wes’s wesbillman account. No new actionable findings in this PR’s seven-file delta.

• Head: d3dbcdc75d5b81af8eb3d547c5d4be298710a35f
• Base: 127f03a5c946209856c7e5021627d4cb40761968 (#292)

Reviewed the documentation, native-capability gate for legacy setup recovery, composition assertion, and the two added browser journeys against their fixture and production callers. The changed recovery branch checks both the snapshot capability and the controller method; configured and older-host paths remain distinct. Browser focus/scroll/layout assertions belong at the browser layer; this review does not establish that they pass.

This disposition covers the changes introduced here, not clearance of previously reported findings in the stacked base.

Validation limits: source-only review of immutable, Git-blob-verified inputs; no dirty checkout inputs. No PR code, tests, builds, browser journeys, app/native workflows, or credential operations were executed. CI was not checked. Rendered layout, native behavior, and human acceptance remain unverified. This is a non-blocking COMMENT, not approval or merge authorization.

[wesbillman]

Star Lord’s automated source review (via Wes’s account)

No new actionable findings in this bounded follow-up. The changed assertions and documentation meet the 9/10 source-review bar for minimalness, elegance and correctness within this scope.

• Head: 30aef9555a5a738313eb2f0ac973820da6292c84
• Base: 294f68fb3dae8a1c7b09935d028415bcd6d0d41e (#292)
• Previously covered head: d3dbcdc75d5b81af8eb3d547c5d4be298710a35f (review)

Compared the actual base-to-head feature delta and pinned old/current blobs. Three of the seven PR files remain byte-identical; separated inherited native-admission, template-selection, npub and agent-editor updates from this PR’s revised inventory documentation and browser assertions.

• The browser case now expects one Stop control and the Actions menu for the saved setup outside the selected community (agent-control.spec.mjs:1404–1407,1455–1458). That matches the current exact-ID control path in InventoryIdentityCard.tsx:72–74,125–139 and ManagedAgentActions.tsx:40–42,126–132. The section supplies its community heading, so suppressing that setup’s duplicate URL remains consistent. These expectation changes preserve controls rather than relax geometry or disclosure checks.
• The new Personal-space import guidance matches the destination input, preview invalidation, explicit reload and commit guards in AgentImport.tsx:175–203,253–266. The startup inventory description matches Store::migrate_legacy (store.rs:184–241) and its startup caller (src-tauri/src/agents.rs:243–244): removed sources/identities are retired per source, while damaged sources retain prior entries and report warnings.
• The previously reviewed native-capability recovery guard, fixture and composition test are unchanged. The single PR commit retains its DCO sign-off. This follow-up does not clear findings on the parent stack or reopen unrelated base changes.

Validation limits: source-only inspection of 39 immutable Git-blob-verified extracts; no dirty checkout inputs. Tests were read, not run; no PR code, builds, installs, app/native workflows or credentials were exercised. One exact-head CI snapshot showed the latest run’s required gate, JavaScript, Rust/tool integration, six browser shards, measurements, security checks and DCO successful; Windows native validation was skipped. The snapshot also contained an earlier cancelled run with a failed aggregate gate. CI was not watched or re-polled. Native/live workflows and human acceptance remain unverified. This non-blocking COMMENT is not approval or merge authorization.

[wesbillman]

No new actionable findings in this documentation-only follow-up. The corrected packaged Use here guidance resolves the prior P3 and matches the native confirmation path and older-host capability gate.

Star Lord’s automated source review via Wes’s account; head 15e03e947410368ca6c946a0e2612d35f286e8ef, base 96ecf7499b674e93f2e85d842688428f8571edb3. Source-only: inspected the description and attached screenshot; no tests or app workflows run, and packaged acceptance remains unverified.

[wesbillman]

No new changes requested in this bounded integration follow-up: the feature files are unchanged from the last review, and the corrected native Use here guidance still matches the capability gate and confirmation path after inspecting inherited style/transport changes.

Star Lord automated source review via Wes’s account; head b76a434ca736fcfc390997691eb15a789812c9dc, base 07933b458fd669bef463d544db2f67b7252998da.

Source-only: description, fixture screenshot and error/retry paths inspected; no tests/apps run, packaged behavior and actual focus/retry remain unexercised, while one hosted CI snapshot showed success with Windows skipped—non-blocking COMMENT, not approval.

[wesbillman]

No new changes requested in this bounded rebase/integration follow-up: the three feature patches are unchanged, and the native Use here documentation correction remains intact.

Star Lord automated source review via Wes’s account — head 067d725b92c10a6f3aa89d578130671da3580752, base fdfbb0fa4b01132946aa922bd05c36a1563bf13d.

I checked the inherited overlap, capability fallback, import error/retry focus paths, and public description/image without finding a new source-demonstrated regression. Source-only: no tests or app execution; several CI jobs were still running in the single snapshot, and packaged/native acceptance remains unverified.

[wesbillman]

No further changes requested in this bounded follow-up. The native Use here documentation correction and older-host guidance remain intact; I found no new actionable defect in the rebased import/control integration or inspected public materials.

Star Lord automated source review via Wes’s account — head 15f8c4d8323b7659f64682e118a615b510c5b54b, base e5a70460a9a3423464e7ee97dede8ccecfd69f10. No code or tests executed; the CI snapshot still had JavaScript and one WebKit shard running, and native/human acceptance and error/retry focus behavior remain unverified.

[wpfleger96]

🤖 one blocking doc fix (the line saying controls only show in the current community, which contradicts the code and this PR's own browser test) and three nonblocking notes inline. the code changes and the new browser tests look good

[wesbillman]

No new actionable findings in this bounded follow-up. The fallback removal is consistent with current native snapshot/configuration semantics; the revised import-source and cross-community control guidance matches its callers.

Star Lord’s automated source review via Wes’s account — head 9fbeefc4075206f002f4668350ac9437a20eb6c0, base 69a9af2360c2e15bfbe35814b217358165e07117.

Source-only: public description/image and error/retry paths inspected, but no tests or app execution. One CI snapshot showed a crowded-tab browser failure and other checks still running; I have not established a causal link to this delta, and native/runtime acceptance remains unverified.

[wpfleger96]

🤖 All four comments from the last review are addressed at 9fbeefc4, and the fix commit doesn't introduce anything new. Approving.

One nonblocking thing: the PR description and its screenshot still describe the older-host "update the desktop app" message that this commit removed. Worth refreshing so the description matches the final diff.

The red CI required check comes from channel-tabs.spec.mjs failing the same way on main, not from this PR. The head after the #516 rebase still needs green required checks before merge.

[loganj]

🤖 Thanks. I updated the description to match the final diff: it no longer describes the older-host "update the desktop app" message, and the stale screenshot is gone. No code change. The red CI required comes from channel-tabs.spec.mjs, which also fails on main; I'll rebase onto main and rerun checks once #516 lands.

[wesbillman]

No new actionable findings in this bounded follow-up. Scoping the crowded-strip assertions to Panel tabs excludes the picker’s Tab categories while preserving counts, geometry tolerances, scrollbar checks and Home/End focus assertions; production source is unchanged from the prior review.

Star Lord’s automated source review via Wes’s account — head aea5fb5bcaa51e0d9fb1e4601a993dfa747b27b3, base 69a9af2360c2e15bfbe35814b217358165e07117. Source-only; no tests or app run. Public material was rechecked (no attachments); the CI snapshot was still running, DCO passed, Windows native validation was skipped, and runtime/native acceptance remains unverified.