🤖 docs(nip-fi): remove implementation references from the spec - #7912
Conversation
…nown-gap note The deny_protected row documents repair-mode behaviour main's code already has. The known-gap paragraph is stale once #7265 wires the real deny map. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
🔐 Codex Security Review
|
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
No blocking findings in this documentation-only patch. Reviewed head a481ea8bfee64468e5b1bbc7a56b43b946d6f27c against base 781d39510cf23cfe224e8f521ae06a23377e06de.
The new denial row preserves the existing fixed HTTP 503 contract. The Blossom note removal is correct under the stated merge order: merge #7265 first, then this PR. That prerequisite is still open; its inspected head ad4174b03247ee7cf9290d7cdb18615144ed90b5 replaces the shared admission stub with the issuer-scoped deny map. The separate Blossom verifier gaps remain documented.
Source-only validation: complete diff and PR-text/privacy scan, HTTP denial mapping, Blossom upload/GET/HEAD pairing, and prerequisite wiring. No PR code, builds, or tests executed. One optional wording correction is inline; no runtime/client behavior changes here.
The spec holds normative text only; compliance notes, crate paths, and PR numbers belong in code and PR history. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
* origin/main: 🤖 docs(nip-fi): remove implementation references from the spec (#7912) fix(relay): fail startup on invalid operator listener config (#7933) fix(db): limit event transactions to listener mention kinds (#7932) feat(relay): deliver pubkey mentions to relay companions (#7793) docs(protocol): propose simplified channel artifacts (#7791) feat(push): support configurable HTTP(S) delivery URLs (#7877) fix(ci): select runtime suites from PR changes only (#7843) test(desktop): synchronize upload edit smoke test (#7903) Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
…in-ui * origin/main: test(desktop): wait for channel head refresh before paging thread summary test (#7955) 🤖 perf: bound long-thread aux reads and make query deadlines terminal (#7854) Add native HPKE encryption for nsec backups (#7849) test(desktop): scope video menu e2e probes to emitted messages (#7953) Add owner deletion admission control plane (#7818) fix(sidebar): converge stale-at-open state across devices (sections/sort/stars/mutes) (#7805) feat(nip-fi): harden Blossom kind-24242 verifier to NIP-FI spec (#7288) Make relay readiness process-local (#7341) 🤖 docs(nip-fi): remove implementation references from the spec (#7912) Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>
This removes implementation references and implementation status from
docs/nips/NIP-FI.mdso the spec holds normative text only. It drops the Blossom compliance note, the known-gap notes, crate/file paths and PR numbers, roadmap "supersedes" sentences, doc-history lines, and the design-rationale note on session-only vs deny-until-TTL (its restart re-push SHOULD remains stated normatively elsewhere).Two wording changes carry normative weight:
PUT /media/uploadis listed as a plain kind-24242 upload route instead of a temporary alias, and the JWKS fetcher's SSRF controls become a MUST instead of a description.It doesn't depend on any enforcement PR and can merge at any time.
Related: #7265