test(desktop): scope video menu e2e probes to emitted messages - #7953
Merged
Merged
Conversation
Bind each context-menu interaction to the exact mock message returned by the emitter so same-second ordering cannot select the wrong video. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: tornquist <tornquist@squareup.com> (cherry picked from commit dfd5db4) Signed-off-by: murderbot <3754f8729004d95654c46dbab3129e4ab9ef05cc2534e2a3fbfc155983bd637b@buzz.block.builderlab.xyz>
🔐 Codex Security Review
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
baxen
enabled auto-merge (squash)
September 28, 2026 19:06
loganj
approved these changes
Sep 28, 2026
loganj
left a comment
Collaborator
There was a problem hiding this comment.
yes, but didn't you implement sub-second ordering?
wesbillman
approved these changes
Sep 28, 2026
wpfleger96
pushed a commit
that referenced
this pull request
Sep 28, 2026
Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com> * origin/main: Add native HPKE encryption for nsec backups (#7849) test(desktop): scope video menu e2e probes to emitted messages (#7953) Add owner deletion admission control plane (#7818) Signed-off-by: Hayt <211b96e6a2b7f45fd4047988976c7bbbeeda0c15f3ae7b32eec20834b5a55118@buzz.block.builderlab.xyz>
johnmatthewtennant
pushed a commit
that referenced
this pull request
Sep 28, 2026
…in-ui * origin/main: test(desktop): wait for channel head refresh before paging thread summary test (#7955) 🤖 perf: bound long-thread aux reads and make query deadlines terminal (#7854) Add native HPKE encryption for nsec backups (#7849) test(desktop): scope video menu e2e probes to emitted messages (#7953) Add owner deletion admission control plane (#7818) fix(sidebar): converge stale-at-open state across devices (sections/sort/stars/mutes) (#7805) feat(nip-fi): harden Blossom kind-24242 verifier to NIP-FI spec (#7288) Make relay readiness process-local (#7341) 🤖 docs(nip-fi): remove implementation references from the spec (#7912) Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
Desktop Smoke E2E (4)failure onmain. The test atdesktop/tests/e2e/video-attachment.spec.ts("right-click menus expose distinct selectors for links, relay video, and off-relay video") fails 3/3 attempts on main and on every PR branch since ~Sept 25. Because "Desktop" is a required check, that blocks merges.Cause: the relay-video and off-relay-video probes picked their player with
getByTestId("video-player").last(). When mock messages share a second, timeline ordering can put a different video last. The locator then resolves to the wrong player, and the "Download video" menu detaches before the click, so the test times out.Fix: scope each probe to the
data-message-idof the messageemitVideoMessagejust returned. Test-only change, 16 lines.Attribution
This is a cherry-pick of
dfd5db4e0by @Tornquist, originally part of #7827 (the deletion-drain cron, which is stacked on another feature branch). It's pulled out on its own so main can go green without waiting on that stack. Authorship is preserved.Testing
pnpm build:e2e && playwright test tests/e2e/video-attachment.spec.ts --project=smoke: 13/13 passed locally, including the target test.🤖 Generated with Claude Code