Skip to content

chore(ci): remove NODE_AUTH_TOKEN once OIDC trusted publishing is enabled - #135

Merged
wyattjoh merged 2 commits into
mainfrom
chore/remove-npm-token-auth
Apr 11, 2026
Merged

chore(ci): remove NODE_AUTH_TOKEN once OIDC trusted publishing is enabled#135
wyattjoh merged 2 commits into
mainfrom
chore/remove-npm-token-auth

Conversation

@wyattjoh

@wyattjoh wyattjoh commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Removes NODE_AUTH_TOKEN from all three npm publish jobs now that OIDC trusted publishing is configured for the package on npmjs.com.

Do not merge until OIDC trusted publishing is enabled on npmjs.com for this package.

Affects:

  • publish-npm (stable release)
  • canary-publish-npm (canary release)
  • publish (snapshot release)

@wyattjoh

wyattjoh commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

Stack: npm-publishing-fixes

Part of a stacked PR chain. Do not merge manually.

@wyattjoh
wyattjoh force-pushed the chore/remove-npm-token-auth branch from bad8910 to 49ee738 Compare April 9, 2026 20:51
@wyattjoh
wyattjoh force-pushed the refactor/scripts-releaser branch from 709cdd8 to eb7ba96 Compare April 9, 2026 20:51
@wyattjoh
wyattjoh force-pushed the chore/remove-npm-token-auth branch from 49ee738 to 62b2b43 Compare April 9, 2026 20:52
@wyattjoh
wyattjoh force-pushed the refactor/scripts-releaser branch from eb7ba96 to 26e0afd Compare April 9, 2026 20:52
@wyattjoh
wyattjoh force-pushed the chore/remove-npm-token-auth branch from 62b2b43 to 111830b Compare April 9, 2026 20:56
@wyattjoh
wyattjoh force-pushed the refactor/scripts-releaser branch 2 times, most recently from 5ea4dbb to 7d8511f Compare April 9, 2026 21:02
@wyattjoh
wyattjoh force-pushed the chore/remove-npm-token-auth branch from 111830b to 9502bf6 Compare April 9, 2026 21:03
@wyattjoh
wyattjoh force-pushed the refactor/scripts-releaser branch from 7d8511f to f031159 Compare April 9, 2026 21:10
@wyattjoh
wyattjoh force-pushed the chore/remove-npm-token-auth branch from 9502bf6 to c6df875 Compare April 9, 2026 21:10
@wyattjoh
wyattjoh force-pushed the chore/remove-npm-token-auth branch from c6df875 to 830c98a Compare April 9, 2026 21:38
@wyattjoh
wyattjoh force-pushed the refactor/scripts-releaser branch from f031159 to 31f96b0 Compare April 9, 2026 21:38
Base automatically changed from refactor/scripts-releaser to main April 9, 2026 21:56
@wyattjoh
wyattjoh force-pushed the chore/remove-npm-token-auth branch from 830c98a to 4ae3d0e Compare April 9, 2026 21:58
@wyattjoh
wyattjoh marked this pull request as ready for review April 9, 2026 21:59
@wyattjoh
wyattjoh marked this pull request as draft April 9, 2026 22:00
@coderabbitai

coderabbitai Bot commented Apr 9, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e76ba2fc-4f0d-4691-8718-30a51d8e2985

📥 Commits

Reviewing files that changed from the base of the PR and between 4ae3d0e and f9175f6.

📒 Files selected for processing (4)
  • .github/workflows/release.yml
  • .github/workflows/snapshot.yml
  • docs/releasing.md
  • scripts/lib/npm.ts
💤 Files with no reviewable changes (1)
  • .github/workflows/snapshot.yml
✅ Files skipped from review due to trivial changes (1)
  • scripts/lib/npm.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

Consolidates CI workflows by deleting .github/workflows/snapshot.yml and folding snapshot behavior into .github/workflows/release.yml: release.yml now also triggers on issue_comment (snapshot comments starting with !snapshot), uses dynamic job-level concurrency for comment events, gates the versioning job to push events, propagates release_created outputs with simplified references, and implements a snapshot pipeline that validates commenter association, captures PR head SHA and fork status, computes optional snapshot names, builds/signs/smoke-tests artifacts, publishes snapshots via OIDC on ubuntu-latest, and comments/reacts on PRs. Additionally, NODE_AUTH_TOKEN was removed from NPM publish steps in release.yml, scripts/lib/npm.ts adds the --provenance flag to npm publish, and docs/releasing.md was updated to reflect the consolidated workflows.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing NODE_AUTH_TOKEN from npm publish jobs in favor of OIDC, which aligns with the primary objective of the pull request.
Description check ✅ Passed The description clearly explains the motivation (OIDC trusted publishing now enabled), lists the affected npm publish jobs, and includes an important blocker warning about merge prerequisites.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@dominic-clerk

Copy link
Copy Markdown
Contributor

I have added a commit combining both release workflows (snapshot.yml and release.yml) as npm allows the configuration of only one trusted workflow.

Here's the claude summary of the changes

What changed:

  • Added issue_comment trigger alongside push — snapshot jobs gate on github.event_name == 'issue_comment', release/canary jobs gate on push
  • Snapshot jobs prefixed with snapshot- to avoid name collisions
  • Concurrency group is now dynamic: release-main for pushes, release-snapshot-{PR#} for snapshot comments
  • Removed NODE_AUTH_TOKEN (OIDC replaces it)
  • Deleted snapshot.yml

No behavioral changes to any of the three release channels (stable, canary, snapshot).

@wyattjoh
wyattjoh marked this pull request as ready for review April 11, 2026 03:48
@wyattjoh
wyattjoh force-pushed the chore/remove-npm-token-auth branch from 49b74e1 to f9175f6 Compare April 11, 2026 03:49
@wyattjoh
wyattjoh merged commit 393873b into main Apr 11, 2026
6 checks passed
@wyattjoh
wyattjoh deleted the chore/remove-npm-token-auth branch April 11, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants