refactor(scripts): consolidate releaser into scripts/lib - #134
Conversation
|
Stack: npm-publishing-fixes Part of a stacked PR chain. Do not merge manually. |
26e0afd to
5ea4dbb
Compare
5ea4dbb to
7d8511f
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughNPM release scripts were changed to run Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
7d8511f to
f031159
Compare
- Move targets to scripts/lib/targets.ts (shared by build, sign-macos, and releaser) - Move run() and publish() helpers into scripts/lib/npm.ts alongside the existing isPublished() - Flatten scripts/releaser/index.ts to scripts/releaser.ts now that the directory only held one file - Update import paths in build.ts, sign-macos.ts, and package.json
f031159 to
31f96b0
Compare
|
!snapshot |
Snapshot publishednpm install -g clerk@0.0.2-snapshot.v20260409214324
|
PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.
PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.
PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.
Reorganizes the scripts directory to reduce nesting and improve cohesion.
scripts/releaser/targets.tstoscripts/lib/targets.ts— already shared bybuild.tsandsign-macos.ts, now lives with other shared lib utilitiesrun()andpublish()toscripts/lib/npm.tsalongside the existingisPublished()— all npm subprocess logic in one placescripts/releaser/index.tstoscripts/releaser.ts— the subdirectory only held one filebuild.ts,sign-macos.ts, andpackage.json