Skip to content

fix(ci): add scripts/lib/ to sign-macos sparse checkout - #143

Merged
wyattjoh merged 1 commit into
mainfrom
fix/sign-macos-sparse-checkout
Apr 10, 2026
Merged

fix(ci): add scripts/lib/ to sign-macos sparse checkout#143
wyattjoh merged 1 commit into
mainfrom
fix/sign-macos-sparse-checkout

Conversation

@rafa-thayto

Copy link
Copy Markdown
Contributor

Summary

  • PR refactor(scripts): consolidate releaser into scripts/lib #134 moved shared helpers to scripts/lib/ and updated sign-macos.ts to import from ./lib/targets.ts
  • The sparse checkout in sign-macos.yml was never updated, so the runner checked out sign-macos.ts but not the lib it depends on
  • Fixes: error: Cannot find module './lib/targets.ts' from '/Users/runner/work/cli/cli/scripts/sign-macos.ts'

Test plan

  • Trigger a snapshot build after merge — the sign-macos job should complete without the missing module error

PR #134 moved shared helpers to scripts/lib/ but the sparse checkout in
sign-macos.yml was never updated, causing `Cannot find module './lib/targets.ts'`.
@coderabbitai

coderabbitai Bot commented Apr 10, 2026

Copy link
Copy Markdown
ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: 7169991e-09c6-4139-91b0-09f6477e61c1

📥 Commits

Reviewing files that changed from the base of the PR and between 6a8c0cd and 8c6e477.

📒 Files selected for processing (1)
  • .github/workflows/sign-macos.yml

📝 Walkthrough

Walkthrough

The sign-macos.yml GitHub Actions workflow has been updated to expand the sparse-checkout configuration. The actions/checkout step now includes scripts/lib/ in its sparse-checkout list, allowing the scripts/sign-macos.ts signing step to access supporting library code from that directory during workflow execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

Comment @coderabbitai help to get the list of available commands and usage tips.

@wyattjoh
wyattjoh merged commit 28b720e into main Apr 10, 2026
6 checks passed
@wyattjoh
wyattjoh deleted the fix/sign-macos-sparse-checkout branch April 10, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants