Skip to content

fix(clerk-js): Correct initial ref value for form feedback#1933

Merged
desiprisg merged 1 commit into
mainfrom
correct_ref_form_feedback
Oct 25, 2023
Merged

fix(clerk-js): Correct initial ref value for form feedback#1933
desiprisg merged 1 commit into
mainfrom
correct_ref_form_feedback

Conversation

@desiprisg

Copy link
Copy Markdown
Contributor

Description

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@changeset-bot

changeset-bot Bot commented Oct 24, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6e99ebd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1,2 @@
---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we add changesets for everything now..

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we do @desiprisg ☝️

@desiprisg
desiprisg added this pull request to the merge queue Oct 24, 2023
@desiprisg
desiprisg removed this pull request from the merge queue due to a manual request Oct 24, 2023
@desiprisg
desiprisg changed the base branch from main to main-v4 October 25, 2023 14:13
@desiprisg
desiprisg requested a review from a team October 25, 2023 14:13
@desiprisg
desiprisg changed the base branch from main-v4 to main October 25, 2023 14:14
@desiprisg
desiprisg added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 74a2cbe Oct 25, 2023
@desiprisg
desiprisg deleted the correct_ref_form_feedback branch October 25, 2023 14:24
github-merge-queue Bot pushed a commit that referenced this pull request Oct 31, 2023
…ntrol of the UI (#1896)

* fix(clerk-js): Correct initial ref value for form feedback (#1933)

* chore(clerk-js): Use `org:sys_domains:read`

* test(clerk-js): Use `org:sys_domains:read`

* chore(clerk-js): Add changeset

* chore(clerk-js): UseDomainList

* feat(clerk-js): Session.isAuthorized now support the `any` parameter

* chore(clerk-js): Improve relative url creation in DomainList

* test(clerk-js): Test cases for trimLeadingSlash

* chore(clerk-js): Address Pr comments

---------

Co-authored-by: George Desipris <73396808+desiprisg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants