Skip to content

fix(clerk-js): Correct initial ref value for form feedback #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
desiprisg merged 1 commit into from
Oct 25, 2023
Merged

fix(clerk-js): Correct initial ref value for form feedback #1933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/odd-lemons-reply.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---

@anagstef anagstef Oct 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we add changesets for everything now..

@dimkl dimkl Oct 30, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we do @desiprisg ☝️

---
8 changes: 3 additions & 5 deletions packages/clerk-js/src/ui/elements/FormControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import type { FieldId } from '@clerk/types';
import type { ClerkAPIError } from '@clerk/types';
import type { ClerkAPIError, FieldId } from '@clerk/types';
import type { PropsWithChildren } from 'react';
import { useRef } from 'react';
import React, { forwardRef, useCallback, useMemo, useState } from 'react';
import React, { forwardRef, useCallback, useMemo, useRef, useState } from 'react';

import type { LocalizationKey } from '../customizables';
import {
Expand Down Expand Up @@ -151,7 +149,7 @@ export const FormFeedback = (props: FormFeedbackProps) => {
const feedbacksRef = useRef<{
a?: Feedback;
b?: Feedback;
}>({ a: { feedback, feedbackType, shouldEnter: true }, b: undefined });
}>({ a: undefined, b: undefined });

const { getFormTextAnimation } = useFormTextAnimation();
const defaultElementDescriptors = {
Expand Down