fix(playbook): improve inline code contrast - #1284
Merged
Merged
Conversation
Contributor
Author
Reviewer mediaDeterministic TUI comparison using the same isolated daemon, Playbook Markdown, viewport, theme, and keystrokes. Before — baseline inline-code renderer (base commit); completed spans use the dark active-highlight foreground on the darker inactive background: After — fixed renderer (PR commit); completed spans use the readable normal foreground while retaining the highlighted background: Local originals are retained at |
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Validation
cargo test -p construct-cli playbook_inline_code -- --nocapturecargo test -p construct-cli playbook_backspace_after_inline_code_reveals_source_editing_form -- --nocapturecargo test -p construct-cli playbook_cursor_math_matches_painted_buffer_differential -- --nocapturecargo test -p construct-e2e --test playbook_view web_playbook_view_full_parity -- --exact --nocapturecargo buildgit diff --check origin/main...HEADAll passed after rebasing onto current
origin/main.cargo fmt --all -- --checkwas inspected but reports repository-wide pre-existing formatting drift across many untouched files; no broad formatting rewrite was applied.Specs
No spec update. This is a presentation bug fix within the accepted inline-code editing rule in spec 0203, not a new reusable semantic.
Reviewer media
A deterministic before/after TUI capture uses the same isolated daemon, Playbook source, viewport, and keystrokes on both sides. Screenshots will be attached in a PR comment.