Skip to content

fix(tui): let Tab focus Playbook selection menu - #1285

Merged
edwin-zvs merged 2 commits into
mainfrom
feat-playbook-selection-menu-tab-focus
Aug 19, 2026
Merged

fix(tui): let Tab focus Playbook selection menu#1285
edwin-zvs merged 2 commits into
mainfrom
feat-playbook-selection-menu-tab-focus

Conversation

@edwin-zvs

@edwin-zvs edwin-zvs commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make bare Tab focus the visible Playbook selection context menu, then cycle its rows
  • make the first Escape dismiss the menu while preserving selected text, so Tab can indent it; a second Escape clears the selection
  • preserve backward menu navigation and selected-text outdent behavior, including Shift+Tab terminal variants
  • retain C-o as a compatibility alias that can reopen a dismissed menu
  • update spec 0196 and focused state, indent, compatibility, and render tests

Verification

  • focused Tab focus / Escape / indentation transition test: 1 passed
  • focused two-Escape state transition test: 1 passed
  • selection-menu render suite: 5 passed
  • run-row focus render test: 1 passed
  • inline-code contrast tests from PR fix(playbook): improve inline code contrast #1284: 2 passed
  • cargo build

Before the final merge-train update, broader validation also passed:

  • all 337 Playbook-filtered CLI tests
  • full CLI suite: 1,429 passed plus reconnect (one confirmed origin/main truecolor baseline test skipped)
  • TUI smoke e2e: 3 passed

Repository-wide cargo fmt --check proposes extensive unrelated churn on untouched main; no formatter churn was applied. git diff --check is clean.

Reviewer media

Not attached: deterministic VHS capture was stopped to prioritize the merge-train handoff.

@edwin-zvs
edwin-zvs merged commit a419c1c into main Aug 19, 2026
1 check passed
@edwin-zvs
edwin-zvs deleted the feat-playbook-selection-menu-tab-focus branch August 19, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant