fix(tui): honor dismissed Playbook selection menu - #1286
Merged
Conversation
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diagnosis
#1285 correctly separated selection_menu from the text selection in key state, but the renderer used unwrap_or_default whenever a non-empty selection existed. After first Esc set selection_menu to None, a passive-looking ghost menu was painted anyway. Tab then reached the editor because no menu existed to focus, and the next Esc cleared the selection, making the painted menu and selection disappear together.
Verification
No spec update: spec 0196 already requires menu absence after first Esc while retaining the selection; this fixes the renderer to honor it.
Reviewer media
Not attached. The behavior is a short transient focus/dismiss sequence, and the frame-level regression directly asserts the passive hint, focused cursor cue, menu body, and dismissed frame without introducing a brittle recording harness.