Skip to content
This repository was archived by the owner on Apr 3, 2018. It is now read-only.
This repository was archived by the owner on Apr 3, 2018. It is now read-only.

Tests should be protected against behavioural changes of dependencies #168

Description

@jodh-intel

PR #165 ended up failing at the Travis stage since .travis.yml does this:

git clone https://github.com/containernetworking/cni.git

Unfortunately, CNI commit 13824487c6f97a8ffde7b4ef10330c75ddc34826 changed the behaviour of the CNI package such that the virtcontainers test TestRemoveNetworkFailureNetworkDoesNotExist failed. That test has been reworked on #167, but we need to find a way to avoid this sort of breakage in future.

Thoughts:

  • add cni as a vendor/ package to virtcontainer.
  • change .travis.yml so that it checks out the "last known good commit of the CNI package.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions