This repository was archived by the owner on Apr 3, 2018. It is now read-only.
pkg: cni: Fix unit testing after CNI plugins update - #167
Merged
Merged
Conversation
In order to follow more closely the CNI specification, some recent changes have been added to the CNI plugins so that they are not failing anymore in case we try to tear down a non existing network. This patch fixes the unit test which was expecting to see a failure. Now, we are expecting a success in removing a network that we've never created before. Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Collaborator
|
LGTM |
Collaborator
|
lgtm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to follow more closely the CNI specification, some recent changes have been added to the CNI plugins so that they are not failing anymore in case we try to tear down a non existing network.
This patch fixes the unit test which was expecting to see a failure. Now, we are expecting a success in removing a network that we've never created before.
This PR fixes issue #166