feat(providers): offer reconnect for auth-class inference failures - #1298
Merged
Merged
Conversation
TheGreatAxios
commented
Oct 2, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Request changes
The branch classifies reconnectable auth failures and adds a scoped reconnect/replay flow.
Findings
src/tui/runner/reconnect-recovery.ts:209— Accepting the reconnect offer replays the failed turn before reconnection succeeds.openReconnectonly opens the interactive add-provider surface (lines 264–270), butapplyReconnectRecoverySelectionimmediately arms and delivers the continuation at lines 210–214; the director consumes that message by starting inference, while the operator has not yet completed OAuth. This can repeat the same credential failure behind the open reconnect UI and consumes the one replay. Please trigger the continuation from the successful connect completion callback instead.
bun run check passes on this head (8,031 tests, 0 failures), and git diff --check 1ba2599...057c290b passes.
TheGreatAxios
commented
Oct 2, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review follow-up · Fix verified
No findings in fix commit 4ddcf4ec.
Opening the scoped reconnect surface no longer delivers a continuation. The one-shot completion callback delivers replay only after a successful connection, while cancellation, failure, committed attempts, and duplicate completion do not replay. Normal /connect remains callback-free.
Verification: all GitHub checks pass; git diff --check 057c290b..4ddcf4ec passes.
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/connectpre-scoped to the failing kind and profile, with replay-once only when nothing is committedVerification
bun run checkpasses (lint, typecheck, dead-exports, build, guarded suite: 8078 pass, 0 fail)Fixes #1295