fix(providers): use catalog provenance for OAuth removal - #1301
Merged
Merged
Conversation
TheGreatAxios
commented
Oct 2, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Fix verified
No findings. OAuth removal now requires matching current catalog profile provenance, preserving inactive/residual OAuth removal while preventing hand-named API-key or keyless namespace collisions from deleting credentials.
Verification: independent review is CLEAN; catalog/provenance suites pass; bun run check passes with 8,147 tests and 0 failures; all GitHub checks pass; git diff --check origin/main...HEAD passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codexProfileorxaiProfilemarkers on the current provider catalog entry.This follow-up to #1297 and #1298 closes the ownership gap left by source-registry authorization: the registry includes only built sources and can retain stale provenance after the catalog transitions to a custom row, while the current catalog reflects auth-store-backed ownership.
Verification
bun test src/auth/remove-provider.test.ts src/tui/provider-remove.test.tspasses (18 tests).bun run checkpasses (8,147 tests, 0 failures).