Per-tenant retention periods#3879
Merged
Merged
Conversation
stevesg
marked this pull request as ready for review
February 25, 2021 12:50
pracucci
requested review from
pracucci and
pstibrany
and removed request for
pstibrany
February 25, 2021 15:09
pracucci
reviewed
Feb 25, 2021
pracucci
left a comment
Contributor
There was a problem hiding this comment.
Very good job 👏 👏 👏 The PR LGTM! I left few nits, but everything should be quick to address 🚀
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
stevesg
force-pushed
the
per-user-retention
branch
from
February 26, 2021 09:36
3e2fb80 to
b0a8267
Compare
Contributor
Author
|
Rebase |
pracucci
approved these changes
Feb 26, 2021
pracucci
left a comment
Contributor
There was a problem hiding this comment.
Good job, LGTM! (modulo a couple of nits)
Contributor
There was a problem hiding this comment.
I see, but the log below will be misleading ("applying retention"). I think we should also check if retention <= 0 to circuit break.
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
pstibrany
approved these changes
Mar 1, 2021
pstibrany
left a comment
Contributor
There was a problem hiding this comment.
LGTM, nice job. Thank you!
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implement per-tenant retention periods by performing block deletion in the Compactor.
Note that I've split the change into three commits to make reviewing it easier:
Which issue(s) this PR fixes:
Fixes #3622
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]