build: stop declaring eslint-plugin-react directly - #829
Merged
Merged
Conversation
eslint.config.mjs is a flat config and does not register this plugin itself. It takes airbnbPlugins.react, airbnbPlugins.reactHooks and airbnbPlugins.reactA11y from eslint-config-airbnb-extended, which carries eslint-plugin-react as a regular dependency at ^7.37.5. The direct entry pinned it exactly at 7.37.5 while airbnb asks for a range, so the declaration was also a second, narrower constraint on a package the config never names. Resolution is unchanged: 7.37.5 is still the newest release satisfying ^7.37.5, so node_modules is identical. This does not move the ESLint 10 ceiling. That comes from eslint-config-airbnb-extended's own peer on eslint ^9.0.0, which no change to the plugin declarations can lift. Verified by linting, the step that resolves plugins.
cigamit
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
eslint.config.mjsis a flat config and never registers this plugin itself. It takesairbnbPlugins.react,airbnbPlugins.reactHooksandairbnbPlugins.reactA11yfromeslint-config-airbnb-extended, which carrieseslint-plugin-reactas a regular dependency at^7.37.5.The direct entry also pinned it exactly at
7.37.5while airbnb asks for a range, so it was a second and narrower constraint on a package the config does not name. Resolution is unchanged: 7.37.5 is still the newest release satisfying^7.37.5, sonode_modulesis identical.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
This does not move the ESLint 10 ceiling, and it is worth being clear about that since the plugin is listed among the cappers. The binding constraint is
eslint-config-airbnb-extended's own peer oneslint: ^9.0.0. The plugins sit downstream of it, so neither removing nor bumping them lifts anything; only an ESLint 10 compatible airbnb-extended will.Verified by linting, which is the step that resolves plugins:
make ui-lint: clean over the whole ofsrc/.make ui-test-general: 1038 tests, all passing.make ui-test-screens: 1941 tests, all passing.eslint-plugin-react-hooksis the same case and sits on the adjacent line, so the two will conflict with each other; whichever merges second wants a one line resolution keeping both removals.