build: stop declaring eslint-plugin-react-hooks directly - #830
Merged
Merged
Conversation
Same case as eslint-plugin-react. eslint.config.mjs takes airbnbPlugins.reactHooks from eslint-config-airbnb-extended, which carries eslint-plugin-react-hooks as a regular dependency at ^7.1.1, the same range the direct entry asked for. Resolution is unchanged at 7.1.1 and node_modules is identical. Verified by linting, the step that resolves plugins.
blaipr
force-pushed
the
build/drop-eslint-plugin-react-hooks
branch
from
September 7, 2026 06:42
04682e6 to
9894a99
Compare
cigamit
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The same case as #829.
eslint.config.mjstakesairbnbPlugins.reactHooksfromeslint-config-airbnb-extended, which carrieseslint-plugin-react-hooksas a regular dependency at^7.1.1, the same range the direct entry asked for. Resolution is unchanged at 7.1.1 andnode_modulesis identical.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
make ui-lint: clean over the whole ofsrc/.make ui-test-general: 1038 tests, all passing.make ui-test-screens: 1941 tests, all passing.This sits on the line directly below the one #829 removes, so the two conflict with each other. Whichever merges second wants a one line resolution that keeps both removals.
As with #829, this does not move the ESLint 10 ceiling: that is
eslint-config-airbnb-extended's own peer oneslint: ^9.0.0.